From owner-svn-ports-all@freebsd.org Sun Jul 5 21:43:50 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7E45034E8FB; Sun, 5 Jul 2020 21:43:50 +0000 (UTC) (envelope-from tcberner@gmail.com) Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B0Mdy1DcSz4QdW; Sun, 5 Jul 2020 21:43:50 +0000 (UTC) (envelope-from tcberner@gmail.com) Received: by mail-qk1-f180.google.com with SMTP id c30so29344797qka.10; Sun, 05 Jul 2020 14:43:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rN8rr6hJWVi2boCi7IZGN4SVGnQmm4VSkfNGxgdOKkc=; b=NsqpyYc1fi1vHvrMnUW1UpVaIjmzyLwPed8e66H+pRaAkWKqAlllrgr9FlTAvn2gQS 6DkHlYCu6Z+5tTEPx2TdA//K0JbYcTVSXlgB6Qhrk5CAukDtx9oxYek8hVZT3YmsHHwQ voJ6pBVShZw6LGU+hJtyyKo/AH7MrkoYY3Lg4ePsR8VxjX2nnCjz37LJq+7RtrNywBR2 ABp0BsI+GuHtActrIDgedi8GIPdGqJRAORQdhr9AcYBzLjBwxSKoGRgCQLLRFqSiximH elI5vm9mcQotGSe86BX4RurOeoblE35yIb5exFnmhhYEtJZlyxvdZuye6QvBJQCVN7IH ob7g== X-Gm-Message-State: AOAM532cWSdgjP6B13uMjMW6oJyIcQBfmrB4rhja8aTEHqIgm7zErYVE k9W9Kf77tqNi9R8unsSkJ6nKhABTBPw= X-Google-Smtp-Source: ABdhPJw67lvLgkpFkarpXkPDRh9fyDab1vCaDS852xdykwcPDCVSF04y7UUCeCddtPp0URJlExthsw== X-Received: by 2002:ae9:e212:: with SMTP id c18mr21848361qkc.348.1593985429272; Sun, 05 Jul 2020 14:43:49 -0700 (PDT) Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com. [209.85.219.54]) by smtp.gmail.com with ESMTPSA id i57sm20530011qte.75.2020.07.05.14.43.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Jul 2020 14:43:49 -0700 (PDT) Received: by mail-qv1-f54.google.com with SMTP id di5so11484159qvb.11; Sun, 05 Jul 2020 14:43:49 -0700 (PDT) X-Received: by 2002:a0c:f307:: with SMTP id j7mr19994165qvl.55.1593985428840; Sun, 05 Jul 2020 14:43:48 -0700 (PDT) MIME-Version: 1.0 References: <202007051920.065JKLK1093017@repo.freebsd.org> <20200705192642.GA32791@FreeBSD.org> In-Reply-To: <20200705192642.GA32791@FreeBSD.org> From: "Tobias C. Berner" Date: Sun, 5 Jul 2020 23:43:37 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r541296 - in head: databases/kexi devel/injeqt textproc/libkolabxml x11/sddm To: Alexey Dokuchaev Cc: "Tobias C. Berner" , ports-committers , svn-ports-all , svn-ports-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4B0Mdy1DcSz4QdW X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; REPLY(-4.00)[] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Jul 2020 21:43:50 -0000 Well, I disagree. I find it exactly the opposite :) mfg Tobias On Sun, 5 Jul 2020 at 21:26, Alexey Dokuchaev wrote: > > On Sun, Jul 05, 2020 at 07:20:21PM +0000, Tobias C. Berner wrote: > > New Revision: 541296 > > URL: https://svnweb.freebsd.org/changeset/ports/541296 > > > > Log: > > Switch to using CMAKE_ON/CMAKE_OFF instead of more clunky CMAKE_ARGS > > > > Modified: head/x11/sddm/Makefile > > ... > > +CMAKE_ON= BUILD_MAN_PAGES > > CMAKE_ARGS= -DUID_MIN=1000 \ > > -DUID_MAX=65000 \ > > -DCMAKE_INSTALL_SYSCONFDIR:PATH=${LOCALBASE}/etc \ > > - -DBUILD_MAN_PAGES=ON \ > > -DRST2MAN_EXECUTABLE=${LOCALBASE}/bin/rst2man.py-${PYTHON_VER} > > This one looks like pessimization. Please be more considerate with these > changes; I, for one, do not like CMAKE_ON/OFF as I find it harder to read > and understand and prefer explicit assignments via CMAKE_ARGS. > > ./danfe