From owner-svn-src-head@freebsd.org  Mon Apr  9 14:17:37 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id C1296F83CB0;
 Mon,  9 Apr 2018 14:17:37 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 3480F76509;
 Mon,  9 Apr 2018 14:17:36 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1])
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w39EHXJh018894;
 Mon, 9 Apr 2018 07:17:33 -0700 (PDT)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: (from freebsd@localhost)
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w39EHXUH018893;
 Mon, 9 Apr 2018 07:17:33 -0700 (PDT) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
Message-Id: <201804091417.w39EHXUH018893@pdx.rh.CN85.dnsmgr.net>
Subject: Re: svn commit: r332092 - in head/sys: amd64/amd64 sys x86/x86
In-Reply-To: <20180409083554.k34hfijxiztwdne6@MacBook-Pro-de-Roger.local>
To: "Roger Pau Monn?" <royger@freebsd.org>
Date: Mon, 9 Apr 2018 07:17:33 -0700 (PDT)
CC: rgrimes@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org
Reply-To: rgrimes@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Apr 2018 14:17:37 -0000

> On Fri, Apr 06, 2018 at 09:17:09AM -0700, Rodney W. Grimes wrote:
> > [ Charset UTF-8 unsupported, converting... ]
> > > Author: royger
> > > Date: Fri Apr  6 11:20:06 2018
> > > New Revision: 332092
> > > URL: https://svnweb.freebsd.org/changeset/base/332092
> > > 
> > > Log:
> > >   remove GiB/MiB macros from param.h
> > >   
> > >   And instead define them in the files where they are used.
> > 
> > It would of been better to "revert" your prior change and
> > make a seperate new commit.  It is rarely desireable to combine
> > a revert of a change with anything.
> 
> A plain revert of r332072 would have left the tree in a broken state,
> because r332073 depends on those macros. IMO it's better to have a
> buildable tree at all times in order for it to be bisectable.

Well a revert of r332073 could of been combined leaving  the tree
building, and in the state before the attempt to do {MG}iB() macros.

-- 
Rod Grimes                                                 rgrimes@freebsd.org