From owner-freebsd-current Fri Nov 12 6:53:18 1999 Delivered-To: freebsd-current@freebsd.org Received: from overcee.netplex.com.au (overcee.netplex.com.au [202.12.86.7]) by hub.freebsd.org (Postfix) with ESMTP id 1B16814D26 for ; Fri, 12 Nov 1999 06:53:12 -0800 (PST) (envelope-from peter@netplex.com.au) Received: from netplex.com.au (localhost [127.0.0.1]) by overcee.netplex.com.au (Postfix) with ESMTP id B2A7A1C6D; Fri, 12 Nov 1999 22:53:10 +0800 (WST) (envelope-from peter@netplex.com.au) X-Mailer: exmh version 2.0.2 2/24/98 To: Bruce Evans Cc: Peter Jeremy , Mark Newton , current@FreeBSD.ORG Subject: Re: panic: nexus_setup_intr: NULL irq resource! In-reply-to: Your message of "Fri, 12 Nov 1999 23:09:59 +1100." Date: Fri, 12 Nov 1999 22:53:10 +0800 From: Peter Wemm Message-Id: <19991112145310.B2A7A1C6D@overcee.netplex.com.au> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Bruce Evans wrote: > On Fri, 12 Nov 1999, Peter Jeremy wrote: > > > On 1999-Nov-12 12:35:01 +1100, Mark Newton wrote: > > >The problem is that the BUS_SETUP_INTR() method for ISA seems to > > >absolutely require the specification of an IRQ, even though IRQ > > >specification is absolutely prohibited for non-master ports in > > >AST-compatible multi-port sio cards. Gah. > > This is fixed differently (directly in the driver) in nsio (dev/sio/sio.c) > rev.1.267. Both fixes are probably necessary and more or less correct. > Drivers shouldn't attempt to register null interrupts, and attempting > this probably shouldn't cause panics. > > > As an aside, why doesn't our SIO driver work with ports that don't > > have interrupts? > > Same problem. Ports that don't have interrupts give polled mode, and > the driver shouldn't attempt to register the null interrupts for polled > mode, but this was broken when the driver was converted to new-bus. > > > >I'm not completely sure that this patch does the right thing > > > > Since your patch effectively turns isa_setup_intr() into a nop for > > this case, a better patch would seem to be to skip the call to > > BUS_SETUP_INTR() (and presumably bus_alloc_resource()) at the end > > of sioattach() when you're attaching a slave SIO port. > > nsio still has the bus_alloc_resource(). This seems to be a harmless > but bogus no-op if the resource isn't there. > > Bruce I think I've got all this fixed (or closer to being fixed) in a merge of some nsio stuff back into sio.c so nsio.c can be zapped for now. Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message