From owner-dev-commits-ports-main@freebsd.org Sat May 29 14:08:43 2021 Return-Path: Delivered-To: dev-commits-ports-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4B1F76414FF; Sat, 29 May 2021 14:08:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Fsk1R1WdGz3FsT; Sat, 29 May 2021 14:08:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 1C4173808; Sat, 29 May 2021 14:08:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 14TE8hJ4091053; Sat, 29 May 2021 14:08:43 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 14TE8hW5091052; Sat, 29 May 2021 14:08:43 GMT (envelope-from git) Date: Sat, 29 May 2021 14:08:43 GMT Message-Id: <202105291408.14TE8hW5091052@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org From: Dimitry Andric Subject: git: 4fb035a886d9 - main - multimedia/smpeg: fix incorrect warning suppression flag. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: ports X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4fb035a886d9d247742f983fdd0afb703cabd975 Auto-Submitted: auto-generated X-BeenThere: dev-commits-ports-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commits to the main branch of the FreeBSD ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 May 2021 14:08:43 -0000 The branch main has been updated by dim (src committer): URL: https://cgit.FreeBSD.org/ports/commit/?id=4fb035a886d9d247742f983fdd0afb703cabd975 commit 4fb035a886d9d247742f983fdd0afb703cabd975 Author: Dimitry Andric AuthorDate: 2021-05-11 11:37:28 +0000 Commit: Dimitry Andric CommitDate: 2021-05-29 14:08:18 +0000 multimedia/smpeg: fix incorrect warning suppression flag. During an exp-run for llvm 12 (see bug 255570), it turned out that multimedia/smpeg does not build with clang 12.0.0: libtool: compile: c++ -DPACKAGE=\"smpeg\" -DVERSION=\"0.4.4\" -I. -I. -O2 -pipe -Wno-error-narrowing -fstack-protector-strong -fno-strict-aliasing -I/usr/local/include/SDL -I/usr/local/include -D_REENTRANT -D_THREAD_SAFE -DTHREADED_AUDIO -DNDEBUG -I.. -DNOCONTROLS -I.. -I../audio -I../video -fno-exceptions -fno-rtti -c huffmantable.cpp -fPIC -DPIC -o .libs/huffmantable.o warning: unknown -Werror warning specifier: '-Wno-error-narrowing' [-Wunknown-warning-option] In file included from huffmantable.cpp:12: ../MPEGaudio.h:129:7: warning: 'register' storage class specifier is deprecated and incompatible with C++17 [-Wdeprecated-register] register int r=(buffer[bitindex>>3]>>(7-(bitindex&7)))&1; ^~~~~~~~~ ../MPEGaudio.h:135:7: warning: 'register' storage class specifier is deprecated and incompatible with C++17 [-Wdeprecated-register] register unsigned short a; ^~~~~~~~~ huffmantable.cpp:553:8: error: constant expression evaluates to -1 which cannot be narrowed to type 'unsigned int' [-Wc++11-narrowing] { 0, 0-1, 0-1, 0, 0, htd33}, ^~~ huffmantable.cpp:553:8: note: insert an explicit cast to silence this issue { 0, 0-1, 0-1, 0, 0, htd33}, ^~~ [... more of these ...] The Makefile attempts to suppress these warnings by adding -Wno-error-narrowing to CFLAGS, in case clang is used, but this warning suppression flag does not exist. It is called -Wno-c++11-narrowing instead, and the attached patch renames the flag. Approved by: maintainer timeout (2 weeks) PR: 255796 MFH: 2021Q2 --- multimedia/smpeg/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/multimedia/smpeg/Makefile b/multimedia/smpeg/Makefile index b61c0b14f8e3..5327f969c50b 100644 --- a/multimedia/smpeg/Makefile +++ b/multimedia/smpeg/Makefile @@ -27,7 +27,7 @@ CONFIGURE_ARGS= --disable-opengl-player \ --disable-gtk-player \ --enable-mmx CFLAGS+= ${CFLAGS_${CHOSEN_COMPILER_TYPE}} -CFLAGS_clang= -Wno-error-narrowing +CFLAGS_clang= -Wno-c++11-narrowing LDFLAGS_i386= -Wl,-znotext MAKE_ARGS= LIBTOOL=${LOCALBASE}/bin/libtool INSTALL_TARGET= install-strip