From owner-svn-src-all@FreeBSD.ORG Sun Jun 14 19:19:38 2015
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by hub.freebsd.org (Postfix) with ESMTPS id C7D70615;
Sun, 14 Jun 2015 19:19:38 +0000 (UTC)
(envelope-from yaneurabeya@gmail.com)
Received: from mail-pd0-x232.google.com (mail-pd0-x232.google.com
[IPv6:2607:f8b0:400e:c02::232])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(Client CN "smtp.gmail.com",
Issuer "Google Internet Authority G2" (verified OK))
by mx1.freebsd.org (Postfix) with ESMTPS id 8D97BF11;
Sun, 14 Jun 2015 19:19:38 +0000 (UTC)
(envelope-from yaneurabeya@gmail.com)
Received: by pdbnf5 with SMTP id nf5so57265309pdb.2;
Sun, 14 Jun 2015 12:19:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
h=content-type:mime-version:subject:from:in-reply-to:date:cc
:content-transfer-encoding:message-id:references:to;
bh=dvyqai7Soou2ARZVJ5zyoT8g96EmpAf4f1ZZVkh/4QU=;
b=eS/Uz6nOu/2A4BspoveMOdqZW6H2Qu87aegUAddOXQeWkdWsl0Mn0xn7c4M7PWXAQm
EfX8Ui5WDWxQ+jjGFVa+69s4j3OpgjUvXR4T3pY+kGULVQMvYW8v3RA4ErOH6yxOaYPt
R+g0YQd1jG9N4fCuv/Bi2Z5vt3NeNG+IT/0zTlAk1nx60Corlqzghw7/GbNQXbCbR0Le
HiEu7fbmvLItpU0PSbBssQ1Z0T6wwiYlpR+VE0DaTfNx7G/ZYZw000j99qrW4rqRPLx+
xQjFcOhrcHzmL8Y1B1sWRXkJ01b3LBl9hlDdGWox5dfUb23v41GnwDHUIgfQLz2/xzJy
mUyw==
X-Received: by 10.70.124.134 with SMTP id mi6mr20677466pdb.104.1434309578127;
Sun, 14 Jun 2015 12:19:38 -0700 (PDT)
Received: from [192.168.20.7] (c-98-247-240-204.hsd1.wa.comcast.net.
[98.247.240.204])
by mx.google.com with ESMTPSA id jt2sm9875361pbc.21.2015.06.14.12.19.37
(version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
Sun, 14 Jun 2015 12:19:37 -0700 (PDT)
Content-Type: text/plain;
charset=us-ascii
Mime-Version: 1.0 (1.0)
Subject: Re: svn commit: r284198 - head/bin/ls
From: Garrett Cooper <yaneurabeya@gmail.com>
X-Mailer: iPhone Mail (12F70)
In-Reply-To: <CAJ-VmomyoF=egqDD-R+iun-LtRhrGK3p8+Srd5uzC6gGHQmMDg@mail.gmail.com>
Date: Sun, 14 Jun 2015 12:19:36 -0700
Cc: Bruce Simpson <bms@fastmail.net>,
Steve Kargl <sgk@troutmask.apl.washington.edu>,
Slawa Olhovchenkov <slw@zxy.spb.ru>, Craig Rodrigues <rodrigc@freebsd.org>,
Marcel Moolenaar <marcel@xcllnt.net>,
"svn-src-head@freebsd.org" <svn-src-head@freebsd.org>,
"svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
Marcel Moolenaar <marcel@freebsd.org>,
"src-committers@freebsd.org" <src-committers@freebsd.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <E5005B17-C45A-4EDD-80F3-E671FA428310@gmail.com>
References: <201506100127.t5A1RdX6051959@svn.freebsd.org>
<20150612204309.11dd3391@kan>
<20150613024916.GA98218@troutmask.apl.washington.edu>
<1434208622.1415.57.camel@freebsd.org>
<C88CB169-12FE-4692-92AA-5C7D41BB61DF@FreeBSD.org>
<557C661F.8080104@freebsd.org>
<860017ED-D754-450C-865D-2D81A30C2212@xcllnt.net>
<CAG=rPVd93Q18aYnSGSf_QH4C08RCq5wsdKQSNYTgWQ2huTbUHQ@mail.gmail.com>
<20150614100045.GF58397@zxy.spb.ru> <557D55CB.5050009@fastmail.net>
<20150614171031.GA5857@troutmask.apl.washington.edu>
<557DCBED.2010804@fastmail.net>
<CAJ-VmoktZTMnva02rTojZeGcd3q5BJ9RHGUHgFA=Ghn=WOxQyw@mail.gmail.com>
<887CD9C6-9807-48AF-A7A6-B33F91901414@gmail.com>
<CAJ-VmomyoF=egqDD-R+iun-LtRhrGK3p8+Srd5uzC6gGHQmMDg@mail.gmail.com>
To: Adrian Chadd <adrian@freebsd.org>
X-Mailman-Approved-At: Sun, 14 Jun 2015 23:03:17 +0000
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for "
user" and " projects" \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Jun 2015 19:19:39 -0000
> On Jun 14, 2015, at 12:07, Adrian Chadd <adrian@freebsd.org> wrote:
>=20
>> On 14 June 2015 at 12:02, Garrett Cooper <yaneurabeya@gmail.com> wrote:
>>=20
>>> On Jun 14, 2015, at 11:53, Adrian Chadd <adrian@freebsd.org> wrote:
>>>=20
>>> We have busybox already - it's called bsdbox, and it's in base, and
>>> we're already using it, and yes, it does pull in libxo. :)
>>>=20
>>> I'm not worried about the size increase of libxo. That's the wrong
>>> thing to focus on. If it gets much more bloated then I'll poke people
>>> with the big "what are you thinking" stick. The issues people have
>>> aren't size related, they're "this API needs improvement and we have
>>> bugs introduced into tools."
>>>=20
>>> I do like how zero percent of the comments are "hey, maybe we need
>>> unit tests that run these tools and ensure they output the right
>>> stuff." If this were ${WORK} and I were ${BOSS}, I'd have asked the
>>> libxo developers to include unit tests before/after for each thing
>>> they broke, so we don't have a repeat of this kind of thing. But, this
>>> apparently isn't ${WORK} and I definitely don't want to be anyones
>>> boss, so..
>>=20
>> Ugh. I'll write the tests ;(...
>=20
> I'm not your boss!
>=20
> (but if you go and do it - great! thankyou! This is what should've
> been neckbearded, not the rest of the thread!)
A part of it, yeah.. Not having manpqges still makes it annoying when I have=
to figure out how things work ;(.
Next time someone else converts ANYTHING to libxo -- write tests FIRST to ma=
ke sure you're not breaking legacy behavior. If you need help figuring out h=
ow to do that, I'll be more than happy to document it on a wiki page, with s=
imple, concise directions.
Thanks!=