Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 6 Jun 2011 08:44:49 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        Henrik Brix Andersen <brix@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Andreas Tobler <andreast@freebsd.org>
Subject:   Re: svn commit: r222449 - in head/sys: conf dev/iicbus powerpc/conf
Message-ID:  <201106060844.49421.jhb@freebsd.org>
In-Reply-To: <C492565E-C634-47F5-9EC1-B2247FE9E438@FreeBSD.org>
References:  <201105291425.p4TEPggZ033861@svn.freebsd.org> <4DE9FEC4.4020507@FreeBSD.org> <C492565E-C634-47F5-9EC1-B2247FE9E438@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday, June 04, 2011 6:01:44 am Henrik Brix Andersen wrote:
> Hi,
> 
> On Jun 4, 2011, at 11:45, Andreas Tobler wrote:
> > The chip itself is not PowerMac specific. It contains four times the 
functionality of the ad7418 which is already in there. (dev/iicbus)
> > 
> > The ofw is only needed to detect the chip and to wire the sensor place to 
the right fan property. I think this could be refactored that it is PowerMac 
only and others could benefit from the driver too.
> 
> Right. Since iicbus(4) is a hinted bus, I believe the current scenario could 
be improved either by having a dynamic hints system (and an OFW specific layer 
that added hints about known devices at runtime) or perhaps an OFW iicbus 
subclass (didn't Nathan start on this in r186833?).

I would vote for the latter.  It is what we do for the ISA bus when PnPBIOS or 
ACPI enumerate devices on it.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201106060844.49421.jhb>