From owner-svn-src-all@FreeBSD.ORG Mon Jun 6 13:08:51 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9ED151065670; Mon, 6 Jun 2011 13:08:51 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 73A938FC19; Mon, 6 Jun 2011 13:08:51 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 106C246B39; Mon, 6 Jun 2011 09:08:51 -0400 (EDT) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 691858A01F; Mon, 6 Jun 2011 09:08:50 -0400 (EDT) From: John Baldwin To: Henrik Brix Andersen Date: Mon, 6 Jun 2011 08:44:49 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110325; KDE/4.5.5; amd64; ; ) References: <201105291425.p4TEPggZ033861@svn.freebsd.org> <4DE9FEC4.4020507@FreeBSD.org> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201106060844.49421.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Mon, 06 Jun 2011 09:08:50 -0400 (EDT) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Andreas Tobler Subject: Re: svn commit: r222449 - in head/sys: conf dev/iicbus powerpc/conf X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jun 2011 13:08:51 -0000 On Saturday, June 04, 2011 6:01:44 am Henrik Brix Andersen wrote: > Hi, > > On Jun 4, 2011, at 11:45, Andreas Tobler wrote: > > The chip itself is not PowerMac specific. It contains four times the functionality of the ad7418 which is already in there. (dev/iicbus) > > > > The ofw is only needed to detect the chip and to wire the sensor place to the right fan property. I think this could be refactored that it is PowerMac only and others could benefit from the driver too. > > Right. Since iicbus(4) is a hinted bus, I believe the current scenario could be improved either by having a dynamic hints system (and an OFW specific layer that added hints about known devices at runtime) or perhaps an OFW iicbus subclass (didn't Nathan start on this in r186833?). I would vote for the latter. It is what we do for the ISA bus when PnPBIOS or ACPI enumerate devices on it. -- John Baldwin