From owner-freebsd-dtrace@FreeBSD.ORG Fri Jun 21 19:02:01 2013 Return-Path: Delivered-To: freebsd-dtrace@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id BE5B7A21 for ; Fri, 21 Jun 2013 19:02:01 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-we0-x22a.google.com (mail-we0-x22a.google.com [IPv6:2a00:1450:400c:c03::22a]) by mx1.freebsd.org (Postfix) with ESMTP id 5933F105B for ; Fri, 21 Jun 2013 19:02:01 +0000 (UTC) Received: by mail-we0-f170.google.com with SMTP id w57so6779352wes.1 for ; Fri, 21 Jun 2013 12:02:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=K2oaNJmfbxLmD8479wD504AgA1gSGC6EVlDQlrd8y1A=; b=M94zXxMRceNhj8DWvwti/B5yQ0NQ5krWbG4MHxN1ab4r7wREPV9XmZBMJYwZPXkny8 7M7m6QS9U8GCJ2ymdBzwaQL5XPatyvV7GPgDPlIwFPUwxDGhn3yOP3+i8prRPeEkCMNz AnKOSUfiErIGSCAItj1DGEsDTFHySwmHYTKFWN8JuUStIloXtob22kb85+jLuySuar7d 0zouTkyGX4HKn85AnjlDL8sjjSPHzgoQbdML0lCjueqC1hEmVSGJnUa2BfJKAbyKRrh3 in4c4Xmu0WEloAnzysQpu9mL7/P34lozRZr/QwrU+33pbIbwr2DlgjBtY+nfJgGe8igZ U+eA== MIME-Version: 1.0 X-Received: by 10.180.106.230 with SMTP id gx6mr3724338wib.6.1371841320465; Fri, 21 Jun 2013 12:02:00 -0700 (PDT) Sender: markjdb@gmail.com Received: by 10.194.242.195 with HTTP; Fri, 21 Jun 2013 12:02:00 -0700 (PDT) In-Reply-To: <20130622070025.GA14663@charmander.mks.com> References: <20130622070025.GA14663@charmander.mks.com> Date: Fri, 21 Jun 2013 15:02:00 -0400 X-Google-Sender-Auth: 9uor-eLJxTshCCCj3ews956V3zM Message-ID: Subject: Re: Patch for the trap handler and some test list sanity From: Mark Johnston To: Jeff Ford Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Cc: freebsd-dtrace@freebsd.org X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Jun 2013 19:02:01 -0000 On Sat, Jun 22, 2013 at 3:00 AM, Mark Johnston wrote: > On Fri, Jun 21, 2013 at 11:47:43AM -0700, Jeff Ford wrote: >> Anton Rang and I did some DTrace work for Isilon that we're trying to ge= t >> back into FreeBSD, but neither of us is a committer - here's the first o= ne. >> >> This moves the check for dtrace trap handlers into the low-level excepti= on >> handler to prevent recursive entry when the trap routine is instrumented= . >> This fixes several tests which previously panicked including >> cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/safety/tst.basename.= d. >> The fix is AMD64 only =96 neither of us has had time to make changes to = i386 >> code as we don=92t use it here. >> >> Also this includes updates to the Makefile for the DTrace tests to >> categorize which ones pass, which ones fail, which ones aren=92t safe to= run >> at all, and which ones sometimes pass and sometimes fail. The list shoul= d >> be correct for both AMD64 and i386. This makes =93make=94, =93make ignor= e=94, and >> =93make flaky=94 safe to run in /tools/test/dtrace. > > Hello, > > I'd be happy to help bring these in. I'll probably need some help > reviewing the first one, but "improve the DTrace test makefile" has been > on my todo list for a while. > > Are they available somewhere? Sorry, didn't see the attachment. I'll take a look tonight. -Mark