From owner-svn-src-head@freebsd.org Tue Dec 12 19:03:45 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 73D17E80469 for ; Tue, 12 Dec 2017 19:03:45 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x232.google.com (mail-io0-x232.google.com [IPv6:2607:f8b0:4001:c06::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 301616C333 for ; Tue, 12 Dec 2017 19:03:45 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x232.google.com with SMTP id n41so98768ioe.1 for ; Tue, 12 Dec 2017 11:03:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=j0dAg8TRB6mkga1RgnhYG94wMBYJAKKnDd/Dh3YR3Kw=; b=oLNIpOr3B5iUqKHFihgkPZG4kBqR8DDRMetRzqyIP+ypJp1lxDIs7UBCmMMJipJmr4 qqaG1vmp7M88QoSWt1pKYPciKhYorV8ObQRIJhhwCcG4KgM2dCMP1UigkNhZUkuts4nU bnUq/gIG5xSTvpEhG4dhQn/Xhaz/DSJ4OAaG9f69Bc/MjY0qyKG1BxGuHgeftbndxCRl al+n4hvi0NNsLJUao0DUV6OUu79hrnuRbeU3aJPwweCOJ+KyAKYOR6rT9B4G0ipwNmwk OO+TJDibnAe5Kb7nwkNroUKUHn3e9ORnR2xqprFVszval9uvdO5AqL160Kp4Jy5IeEcz eMyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=j0dAg8TRB6mkga1RgnhYG94wMBYJAKKnDd/Dh3YR3Kw=; b=Y/CIYpZklmSE82yHJw+UGd318YpcAh2o9GZVJy7R51EojdJ+zW40ixcia2MImWVbRa HGcLmNxh30PXglKSwfwbWGeId7XguzbkN0LSA2hx7HtIYXSF6ft6TofUReuWj4lYyaWi 1hIdxh7XTTCXmmBonDElyhPw3NqvbbW3Pih1xSUF/f929nJjsXFldqbO0VhkCG5PstE6 5hHY4p6ee8K6AOxI6cyjDWTJyd8Vz/M75DUxuOwZoBkwuO9jBbMDiMY0zStoCB5neUIv VNKiv6BIUX9O09rInnpG0kLO8mhdRaGOg1C/xsHjOotiD1SHyU8VfUV/51RjtjJKr4SQ NAkA== X-Gm-Message-State: AKGB3mIAE+MmoD5SIb+Rh7V3/cAShba7MnEE5b4rH9Motgxndm9E5XRu oQjbFK+IVuI6OXd9G3G1nUZI16HIjuGG0kqDs8JVrQ== X-Google-Smtp-Source: ACJfBovb1qSv1lxpRgTCU3gCam653S946VaPW1ZDdsEaXKaw970dBD2T1du6R9DNmkA0FuLXHPO1v45Xe8Zs5U4jN3k= X-Received: by 10.107.30.81 with SMTP id e78mr6299050ioe.130.1513105424306; Tue, 12 Dec 2017 11:03:44 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.108.204 with HTTP; Tue, 12 Dec 2017 11:03:43 -0800 (PST) X-Originating-IP: [12.227.204.186] In-Reply-To: References: <201712120946.vBC9krNL075725@repo.freebsd.org> From: Warner Losh Date: Tue, 12 Dec 2017 12:03:43 -0700 X-Google-Sender-Auth: AF8mCw2IeF6gtRcsQRGhRnpeMjw Message-ID: Subject: Re: svn commit: r326792 - head/stand/uboot/common To: Antoine Brodin Cc: src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Dec 2017 19:03:45 -0000 The email I wrote here also sucks. It was unduly harsh. While the commit message should have been better, I was too harsh in trying to express this and giving a better example. Warner On Tue, Dec 12, 2017 at 5:49 AM, Warner Losh wrote: > This commit message sucks. Please use a more descriptive one in the future > like "catch up to change rXXXXX that remove the argument from interact." If > you want to be snarky, add 'pounty hat to imp' to it. Thats infornative. > Your message is utterly useless. It doesn't even say what arch is broken. > > Warner > > Warner > > On Dec 12, 2017 1:47 AM, "Antoine Brodin" wrote: > >> Author: antoine >> Date: Tue Dec 12 09:46:53 2017 >> New Revision: 326792 >> URL: https://svnweb.freebsd.org/changeset/base/326792 >> >> Log: >> Attempt to unbreak buildworld >> >> Modified: >> head/stand/uboot/common/main.c >> >> Modified: head/stand/uboot/common/main.c >> ============================================================ >> ================== >> --- head/stand/uboot/common/main.c Tue Dec 12 06:56:21 2017 >> (r326791) >> +++ head/stand/uboot/common/main.c Tue Dec 12 09:46:53 2017 >> (r326792) >> @@ -500,7 +500,7 @@ main(int argc, char **argv) >> archsw.arch_readin = uboot_readin; >> archsw.arch_autoload = uboot_autoload; >> >> - interact(NULL); /* doesn't return */ >> + interact(); /* doesn't return */ >> >> return (0); >> } >> >>