From owner-svn-src-projects@freebsd.org Thu Sep 17 02:03:52 2020 Return-Path: Delivered-To: svn-src-projects@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A6B8F3F7B3B for ; Thu, 17 Sep 2020 02:03:52 +0000 (UTC) (envelope-from rmacklem@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BsKyJ3fmrz4Z2r; Thu, 17 Sep 2020 02:03:52 +0000 (UTC) (envelope-from rmacklem@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 60F3822C3D; Thu, 17 Sep 2020 02:03:52 +0000 (UTC) (envelope-from rmacklem@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 08H23qL9099539; Thu, 17 Sep 2020 02:03:52 GMT (envelope-from rmacklem@FreeBSD.org) Received: (from rmacklem@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 08H23qwD099538; Thu, 17 Sep 2020 02:03:52 GMT (envelope-from rmacklem@FreeBSD.org) Message-Id: <202009170203.08H23qwD099538@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: rmacklem set sender to rmacklem@FreeBSD.org using -f From: Rick Macklem Date: Thu, 17 Sep 2020 02:03:52 +0000 (UTC) To: src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: svn commit: r365828 - projects/nfs-over-tls/usr.sbin/rpc.tlsservd X-SVN-Group: projects X-SVN-Commit-Author: rmacklem X-SVN-Commit-Paths: projects/nfs-over-tls/usr.sbin/rpc.tlsservd X-SVN-Commit-Revision: 365828 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Sep 2020 02:03:52 -0000 Author: rmacklem Date: Thu Sep 17 02:03:51 2020 New Revision: 365828 URL: https://svnweb.freebsd.org/changeset/base/365828 Log: Oops, used the wrong free() function to free a X509 certificate. Modified: projects/nfs-over-tls/usr.sbin/rpc.tlsservd/rpc.tlsservd.c Modified: projects/nfs-over-tls/usr.sbin/rpc.tlsservd/rpc.tlsservd.c ============================================================================== --- projects/nfs-over-tls/usr.sbin/rpc.tlsservd/rpc.tlsservd.c Thu Sep 17 01:23:16 2020 (r365827) +++ projects/nfs-over-tls/usr.sbin/rpc.tlsservd/rpc.tlsservd.c Thu Sep 17 02:03:51 2020 (r365828) @@ -587,6 +587,8 @@ rpctlssd_verbose_out("get_shutdown1=%d\n", ret); SSL_shutdown(slp->ssl); } SSL_free(slp->ssl); + if (slp->cert != NULL) + X509_free(slp->cert); /* * For RPC-over-TLS, this upcall is expected * to close off the socket. @@ -594,7 +596,6 @@ rpctlssd_verbose_out("get_shutdown1=%d\n", ret); if (!slp->shutoff) shutdown(slp->s, SHUT_WR); close(slp->s); - free(slp->cert); free(slp); result->reterr = RPCTLSERR_OK; } else