From owner-freebsd-stable@FreeBSD.ORG Wed Aug 16 20:49:37 2006 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0D3AA16A4E1 for ; Wed, 16 Aug 2006 20:49:37 +0000 (UTC) (envelope-from thompsa@freebsd.org) Received: from grunt8.ihug.co.nz (grunt8.ihug.co.nz [203.109.254.48]) by mx1.FreeBSD.org (Postfix) with ESMTP id 786B943D46 for ; Wed, 16 Aug 2006 20:49:34 +0000 (GMT) (envelope-from thompsa@freebsd.org) Received: from 203-109-251-39.static.bliink.ihug.co.nz (heff.fud.org.nz) [203.109.251.39] by grunt8.ihug.co.nz with esmtp (Exim 3.35 #1 (Debian)) id 1GDSKO-0004U6-00; Thu, 17 Aug 2006 08:49:28 +1200 Received: by heff.fud.org.nz (Postfix, from userid 1001) id 4F3F11CC25; Thu, 17 Aug 2006 08:49:27 +1200 (NZST) Date: Thu, 17 Aug 2006 08:49:27 +1200 From: Andrew Thompson To: Brooks Davis Message-ID: <20060816204927.GA73369@heff.fud.org.nz> References: <20060815040736.2f85f090.drl@MyBSD.org.my> <9405D801-3435-419A-9541-E1A9B2CF26D2@lassitu.de> <20060816081130.GB81271@comp.chem.msu.su> <20060816145419.GB62485@lor.one-eyed-alien.net> <20060816155844.GA85503@comp.chem.msu.su> <20060816171524.GA63928@lor.one-eyed-alien.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060816171524.GA63928@lor.one-eyed-alien.net> User-Agent: Mutt/1.5.11 Cc: Yar Tikhiy , freebsd-stable@freebsd.org, Stefan Bethke , drl@MyBSD.org.my Subject: Re: Default route (IPv4) demolished by destroying clone (gif/gre) interface X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Aug 2006 20:49:37 -0000 On Wed, Aug 16, 2006 at 12:15:25PM -0500, Brooks Davis wrote: > On Wed, Aug 16, 2006 at 07:58:44PM +0400, Yar Tikhiy wrote: > > On Wed, Aug 16, 2006 at 09:54:19AM -0500, Brooks Davis wrote: > > > On Wed, Aug 16, 2006 at 10:23:13AM +0200, Stefan Bethke wrote: > > > > > > > > Ouch. Don't ppp(8), OpenVPN etc. destroy the tun interface they're > > > > using when they exit? Flushing all routes then would be rather > > > > harmful. I'm glad I haven't updated to a newer -stable yet then :-) > > > > > > In general, no since tun interfaces can not be destroyed. > > > > Did you mean "in particular"? :-) > > > > The problem can be triggered by destroying any interface that can > > be destroyed. Just imagine getting rid of a defunct gif tunnel on > > a remote router, or removing an unused vlan, and totally losing > > connectivity to the router due to its default route having been > > flushed. The scenario still can be quite unpleasant. I'd rather > > change the default for $removable_route_flush to NO and let the > > kernel choose which routes should be flushed upon the physical > > ejection or software destruction of an interface. Note that this > > doesn't include static_routes_${ifn}, which are handled separately > > by pccard_ether_stop(). > > Agreed. That code shouldn't be on by default. I've disabled in it HEAD > and will MFC in a few days. As another poster said, I'm not even sure > it should exist as an option. Thanks for fixing this up, it certainly was odd to be flushing routes in userland. I have one more bug report from the ifnet/devd change to look at where renamed interfaces give some sort of an error. cheers, Andrew