From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Jan 3 16:10:14 2011 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0EE4E1065672 for ; Mon, 3 Jan 2011 16:10:14 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id F22A58FC14 for ; Mon, 3 Jan 2011 16:10:13 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p03GADMT080164 for ; Mon, 3 Jan 2011 16:10:13 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p03GAD2D080163; Mon, 3 Jan 2011 16:10:13 GMT (envelope-from gnats) Date: Mon, 3 Jan 2011 16:10:13 GMT Message-Id: <201101031610.p03GAD2D080163@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Anonymous Cc: Subject: Re: ports/153650: [maintainer update] audio/libmikmod X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Anonymous List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jan 2011 16:10:14 -0000 The following reply was made to PR ports/153650; it has been noted by GNATS. From: Anonymous To: Gleb Sushko Cc: freebsd-gnats-submit@FreeBSD.org Subject: Re: ports/153650: [maintainer update] audio/libmikmod Date: Mon, 03 Jan 2011 19:01:04 +0300 Gleb Sushko writes: > @@ -6,16 +6,12 @@ > # > > PORTNAME= libmikmod > -PORTVERSION= 3.1.11 > -PORTREVISION= 2 > +PORTVERSION= 3.1.12 > +PORTREVISION= 3 You don't need to bump PORTREVISION when updating PORTVERSION. > @@ -41,8 +37,6 @@ > > post-extract: > @${RM} -f ${WRKSRC}/docs/mikmod.info-* > - > -post-patch: > @${REINPLACE_CMD} \ > -e 's|\$$CFLAGS -pthread|\$$CFLAGS ${PTHREAD_CFLAGS}|g' \ > -e 's|-pthread \$$REENTRANT|\$$REENTRANT ${PTHREAD_CFLAGS}|g' \ Why? `make extract' should produce non-modified sources. > diff -ruN old/files/patch-CVE mikmod/files/patch-CVE > --- old/files/patch-CVE 1970-01-01 07:00:00.000000000 +0700 > +++ mikmod/files/patch-CVE 2011-01-03 21:41:32.000000000 +0700 Please, don't remove CVE identifer from patch name. libmikmod has more than one. http://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=libmikmod