From owner-svn-src-all@FreeBSD.ORG Mon May 4 20:01:38 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CC46359B; Mon, 4 May 2015 20:01:38 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A60AB1E9B; Mon, 4 May 2015 20:01:38 +0000 (UTC) Received: from ralph.baldwin.cx (pool-173-54-116-245.nwrknj.fios.verizon.net [173.54.116.245]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 9EE72B915; Mon, 4 May 2015 16:01:36 -0400 (EDT) From: John Baldwin To: Gleb Smirnoff Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r282280 - in head/sys/dev: e1000 ixgbe ixl Date: Mon, 04 May 2015 16:01:28 -0400 Message-ID: <2463555.FfYUgqxYi8@ralph.baldwin.cx> User-Agent: KMail/4.14.2 (FreeBSD/10.1-STABLE; KDE/4.14.2; amd64; ; ) In-Reply-To: <20150504185125.GL34544@FreeBSD.org> References: <201504301823.t3UINd74073186@svn.freebsd.org> <26088556.xbkUe5VAyp@ralph.baldwin.cx> <20150504185125.GL34544@FreeBSD.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Mon, 04 May 2015 16:01:36 -0400 (EDT) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 May 2015 20:01:38 -0000 On Monday, May 04, 2015 09:51:25 PM Gleb Smirnoff wrote: > John, > > On Mon, May 04, 2015 at 09:58:49AM -0400, John Baldwin wrote: > J> > J> > J> So the importaing thing here is that if_get_counter() is still doing > J> > J> > J> per-ifnet stats. The stat you underlined above is per-queue instead. > J> > J> > J> We well need more explicitly knowledge of queues outside of drivers > J> > J> > J> and in the stack itself to support a generic framework for per-queue > J> > J> > J> stats. > J> > J> > > J> > J> > This depends on how generic we want the API to be. Of course, we can add > J> > J> > an extra argument to if_get_counter(). > J> > J> > > J> > J> > However, if we don't expect the number of queues to exceed a reasonable > J> > J> > number of 255 :), we can fit the functionality into existing API. > J> > J> > We can keep the queue number in the highest 8 bits of the ift_counter > J> > J> > parameter. > J> > J> > > J> > J> > #define IFCOUNTER_MASK 0x00ffffff > J> > J> > #define IFCOUNTER_QUEUE(c) ((c) >> 24) > J> > J> > J> > J> I'd prefer that expose queues more directly and figure out how to handle > J> > J> per-queue stats then (e.g. do we have some sort of driver-independent > J> > J> structure that each ifnet has 1 or more of that maps to a queue and has > J> > J> driver provided methods, etc. If so you could have a driver method for > J> > J> queue stats). Note that I did use if_get_counter to report the > J> > J> per-interface stats instead of adding a new sysctl. > J> > > J> > What do you prefer: an extra argument to the if_get_counter() or a extra > J> > ifop? > J> > J> As I said, I'd prefer we expose queues to the stack more directly complete > J> with per-queue ops (e.g. I'd like a per-queue if_transmit thing, though > J> probably more like the old if_start). > > Your answer seems quite orthogonal to my question. I reread it couple of times, > but still can't figure out how exactly do you prefet to fetch per-queue stats. > Can you please explain in more detail? struct if_queue { struct ifnet *ifq_parent; void (*ifq_get_counter)(struct if_queue *, ift_counter); ... }; (Pretend that if_queue is a new object type and that each RX or TX queue on a NIC has one.) -- John Baldwin