From owner-freebsd-scsi@FreeBSD.ORG Fri Feb 27 18:02:53 2004 Return-Path: Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9603816A4CE for ; Fri, 27 Feb 2004 18:02:53 -0800 (PST) Received: from tx1.oucs.ox.ac.uk (tx1.oucs.ox.ac.uk [129.67.1.167]) by mx1.FreeBSD.org (Postfix) with ESMTP id 24DEA43D1D for ; Fri, 27 Feb 2004 18:02:53 -0800 (PST) (envelope-from colin.percival@wadham.ox.ac.uk) Received: from scan1.oucs.ox.ac.uk ([129.67.1.166] helo=localhost) by tx1.oucs.ox.ac.uk with esmtp (Exim 4.24) id 1Awtoa-0006e2-H9 for scsi@freebsd.org; Sat, 28 Feb 2004 02:02:52 +0000 Received: from rx1.oucs.ox.ac.uk ([129.67.1.165]) by localhost (scan1.oucs.ox.ac.uk [129.67.1.166]) (amavisd-new, port 25) with ESMTP id 25237-06 for ; Sat, 28 Feb 2004 02:02:52 +0000 (GMT) Received: from gateway.wadham.ox.ac.uk ([163.1.161.253]) by rx1.oucs.ox.ac.uk with smtp (Exim 4.24) id 1Awtoa-0006dz-3j for scsi@freebsd.org; Sat, 28 Feb 2004 02:02:52 +0000 Received: (qmail 3862 invoked by uid 0); 28 Feb 2004 02:02:52 -0000 Received: from colin.percival@wadham.ox.ac.uk by gateway by uid 71 with qmail-scanner-1.16 (sweep: 2.14/3.71. spamassassin: 2.53. Clear:. Processed in 1.721972 secs); 28 Feb 2004 02:02:52 -0000 X-Qmail-Scanner-Mail-From: colin.percival@wadham.ox.ac.uk via gateway X-Qmail-Scanner: 1.16 (Clear:. Processed in 1.721972 secs) Received: from dhcp1131.wadham.ox.ac.uk (HELO piii600.wadham.ox.ac.uk) (163.1.161.131) by gateway.wadham.ox.ac.uk with SMTP; 28 Feb 2004 02:02:50 -0000 Message-Id: <6.0.1.1.1.20040228020016.03f029e0@imap.sfu.ca> X-Sender: cperciva@imap.sfu.ca (Unverified) X-Mailer: QUALCOMM Windows Eudora Version 6.0.1.1 Date: Sat, 28 Feb 2004 02:02:46 +0000 To: scsi@freebsd.org From: Colin Percival Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Subject: Fwd: commit approval? X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Feb 2004 02:02:53 -0000 I don't think anyone approved this patch -- is it ok with you guys? Colin Percival > > Compare the *number* of patterns to zero, not the *pointer* to the > > patterns. (These lines are correct the other two times they appear.) > > > > Reported by: "Ted Unangst" > > > > Index: src/sys/cam/cam_xpt.c > > =================================================================== > > RCS file: /home/ncvs/src/sys/cam/cam_xpt.c,v > > retrieving revision 1.135 > > diff -u -r1.135 cam_xpt.c > > --- src/sys/cam/cam_xpt.c 9 Nov 2003 02:22:33 -0000 1.135 > > +++ src/sys/cam/cam_xpt.c 20 Feb 2004 15:34:32 -0000 > > @@ -1882,7 +1882,7 @@ > > * If there are no match entries, then this device matches no > > * matter what. > > */ > > - if ((patterns == NULL) || (patterns == 0)) > > + if ((patterns == NULL) || (num_patterns == 0)) > > return(DM_RET_DESCEND | DM_RET_COPY); > > > > for (i = 0; i < num_patterns; i++) {