From owner-freebsd-current@freebsd.org Thu Jan 4 20:43:06 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 625BDEB5B73 for ; Thu, 4 Jan 2018 20:43:06 +0000 (UTC) (envelope-from leonardofogel@yahoo.com.br) Received: from sonic307-3.consmr.mail.bf2.yahoo.com (sonic307-3.consmr.mail.bf2.yahoo.com [74.6.134.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2D097804FA for ; Thu, 4 Jan 2018 20:43:05 +0000 (UTC) (envelope-from leonardofogel@yahoo.com.br) X-YMail-OSG: RbmyjDUVM1kJIDKJJzK_Aizm7rCEaVE7FjcKOxUEGQGJPkfcDnAy.JXg_l.nmBX MCsfeF7P_qkSYgFvwksaMyPiBpYMRWQYTaqoKDgG1_Xpbw9JBUAGnxzhrmtXnaN_UjNrShpts7Ih hnskEyPmqrx.3vwpeBXwbOp43G1iibcx0TBtHm59PUipkz1zr.x267J_ahO4uRPfbfvgq.EQ7flo z7npNMgeEHkVLv7AI4LYWevwZXLpkDSn_wv11_m7QxzaCeD2LpFJddTq4zPXxc2fvCpK06WY_foS g7vzBPbB5jar8w.IHWwaCeLaUi5_ySo0LZoE243KUuS7fz9Ny4hrD5kiXD6ukFxD8eFFiX3XAJCt 9plPcALsnUep0IPP4LLcNDIT8LA_N5RRIVdrl83oVTwMQgbTVLVP_3B3vCBI8sCiTEPKkzyj98Cv to_1eVGOqeOwz0SGuQs16BIbHE5l6ZVszs6U1MagjxVzLADW.89Oe1QGhWsKJhi1SmsQA01ipoPh 7JEjPWFpxVg.odsdKPw-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.bf2.yahoo.com with HTTP; Thu, 4 Jan 2018 20:43:03 +0000 Date: Thu, 4 Jan 2018 20:42:58 +0000 (UTC) From: Leonardo Fogel Reply-To: Leonardo Fogel To: Message-ID: <1106737441.618504.1515098578398@mail.yahoo.com> Subject: To which list should I submit a patch? MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit References: <1106737441.618504.1515098578398.ref@mail.yahoo.com> X-Mailer: WebService/1.1.11150 YahooMailBasic Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0 X-Mailman-Approved-At: Thu, 04 Jan 2018 21:17:09 +0000 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jan 2018 20:43:06 -0000 Hi, I have written a short patch that replaces the legacy interface make_dev(9) with the newer one make_dev_s(9) in the DEV_MODULE(9) man page and in an example that is included in the base. I do not know if I should submit it as a PR to "Base System" (since they are in the base tree) or to "Documentation". Please, could you kindly give me some suggestion? Thank you for your time. Index: src/share/examples/kld/cdev/module/cdevmod.c =================================================================== --- src/share/examples/kld/cdev/module/cdevmod.c (revision 327530) +++ src/share/examples/kld/cdev/module/cdevmod.c (working copy) @@ -109,6 +109,7 @@ cdev_load(module_t mod, int cmd, void *arg) { int err = 0; + struct make_dev_args mda; switch (cmd) { case MOD_LOAD: @@ -120,9 +121,15 @@ printf("Copyright (c) 1998\n"); printf("Rajesh Vaidheeswarran\n"); printf("All rights reserved\n"); - sdev = make_dev(&my_devsw, 0, UID_ROOT, GID_WHEEL, 0600, "cdev"); - break; /* Success*/ + make_dev_args_init(&mda); + mda.mda_devsw = &my_devsw; + mda.mda_uid = UID_ROOT; + mda.mda_gid = GID_WHEEL; + mda.mda_mode = 0600; + err = make_dev_s(&mda, &sdev, "cdev"); + break; + case MOD_UNLOAD: printf("Unloaded kld character device driver\n"); destroy_dev(sdev); Index: src/share/man/man9/DEV_MODULE.9 =================================================================== --- src/share/man/man9/DEV_MODULE.9 (revision 327530) +++ src/share/man/man9/DEV_MODULE.9 (working copy) @@ -58,11 +58,13 @@ .Xr DECLARE_MODULE 9 for more information). The event handler is supposed to create the device with -.Fn make_dev +.Fn make_dev_s on load and to destroy it when it is unloaded using .Fn destroy_dev . .Sh EXAMPLES .Bd -literal +#include +#include #include #include @@ -74,11 +76,17 @@ foo_load(module_t mod, int cmd, void *arg) { int err = 0; + struct make_dev_args mda; switch (cmd) { case MOD_LOAD: - sdev = make_dev(&foo_devsw, 0, UID_ROOT, GID_WHEEL, 0600, "foo"); - break; /* Success*/ + make_dev_args_init(&mda); + mda.mda_devsw = &foo_devsw; + mda.mda_uid = UID_ROOT; + mda.mda_gid = GID_WHEEL; + mda.mda_mode = 0600; + err = make_dev_s(&mda, &sdev, "foo"); + break; case MOD_UNLOAD: case MOD_SHUTDOWN: