From owner-freebsd-bluetooth@FreeBSD.ORG Thu Feb 16 13:00:05 2006 Return-Path: X-Original-To: freebsd-bluetooth@freebsd.org Delivered-To: freebsd-bluetooth@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6B9FD16A420; Thu, 16 Feb 2006 13:00:05 +0000 (GMT) (envelope-from markus@brueffer.de) Received: from mailout11.sul.t-online.com (mailout11.sul.t-online.com [194.25.134.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 58ECD43D49; Thu, 16 Feb 2006 13:00:04 +0000 (GMT) (envelope-from markus@brueffer.de) Received: from fwd27.aul.t-online.de by mailout11.sul.t-online.com with smtp id 1F9ijq-0008Uj-00; Thu, 16 Feb 2006 14:00:02 +0100 Received: from ramses.kicks-ass.net (SaTfB2ZCQeXzk3uSgvf7sKhFaxE64UBV9mXLj35A0076s4-mSKL7wT@[80.143.206.102]) by fwd27.sul.t-online.de with esmtp id 1F9iiY-1HrKcq0; Thu, 16 Feb 2006 13:58:42 +0100 Received: from localhost (dslb-084-061-048-181.pools.arcor-ip.net [84.61.48.181]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ramses.kicks-ass.net (Postfix) with ESMTP id F26EEB833; Thu, 16 Feb 2006 13:58:45 +0100 (CET) From: Markus Brueffer To: Alexander Leidinger Date: Thu, 16 Feb 2006 13:57:48 +0100 User-Agent: KMail/1.9.1 References: <200602151551.27188.markus@brueffer.de> <20060216084717.yyj986z4ckow4w0w@netchild.homeip.net> In-Reply-To: <20060216084717.yyj986z4ckow4w0w@netchild.homeip.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1249937.euqofBNrL1"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200602161357.54103.markus@brueffer.de> X-ID: SaTfB2ZCQeXzk3uSgvf7sKhFaxE64UBV9mXLj35A0076s4-mSKL7wT@t-dialin.net X-TOI-MSGID: ee67091d-6302-44ad-a539-0d43bb56a1bd Cc: freebsd-bluetooth@freebsd.org, freebsd-usb@freebsd.org Subject: Re: [Patch] Fix collection entry parsing in libusbhid X-BeenThere: freebsd-bluetooth@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Using Bluetooth in FreeBSD environments List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Feb 2006 13:00:05 -0000 --nextPart1249937.euqofBNrL1 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Am Thursday 16 February 2006 08:47 schrieb Alexander Leidinger: > Markus Brueffer wrote: > > Furthermore I have removed the loop in REPORT_SAVED_COLL. If someone > > knows why > > it was there in the first place, please share your wisdom :) > > This is done in many places in the source. It's a common way of writting a > macro which is usable like a function (yes, this macro returns, so it > doesn't _work_ like a function, but this is not the point). Usually this = is > used with macros which take arguments. You just can add a ';' after the u= se > of the macro without having to remember if you need to do it, or if your > compiler may moan because of an empty statement. > > Have a look into style(9), it also has to say something about it. Ah, I see. Thanks for the explanation. I have updated the diff to not remov= e=20 the loop. Markus =2D-=20 Markus Brueffer =C2=A0 =C2=A0| GPG-Key: http://people.FreeBSD.org/~markus/m= arkus.asc markus@brueffer.de | FP: 3F9B EBE8 F290 E5CC 1447 8760 D48D 1072 78F8 A8D4 markus@FreeBSD.org | FreeBSD: The Power to Serve! --nextPart1249937.euqofBNrL1 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQBD9HbS1I0Qcnj4qNQRAlckAKCdeI1StIqz0d+WbGY3Sqci21xFlwCgmKai tR9oKVuJNuh//emY4O3mW1s= =HQbF -----END PGP SIGNATURE----- --nextPart1249937.euqofBNrL1--