From owner-freebsd-gnome@freebsd.org Tue Jan 16 03:12:45 2018 Return-Path: Delivered-To: freebsd-gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EEE44EBF199 for ; Tue, 16 Jan 2018 03:12:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id C4EAA80E05 for ; Tue, 16 Jan 2018 03:12:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id C4498EBF198; Tue, 16 Jan 2018 03:12:45 +0000 (UTC) Delivered-To: gnome@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C3E62EBF197 for ; Tue, 16 Jan 2018 03:12:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AB45D80E04 for ; Tue, 16 Jan 2018 03:12:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 9EB7F23374 for ; Tue, 16 Jan 2018 03:12:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w0G3CjV7028902 for ; Tue, 16 Jan 2018 03:12:45 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w0G3CjgS028900 for gnome@FreeBSD.org; Tue, 16 Jan 2018 03:12:45 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: maintainer-feedback requested: [Bug 225206] devel/xdg-utils: xdg-mime has bogus patch to use stat -f Date: Tue, 16 Jan 2018 03:12:44 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: gnome@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jan 2018 03:12:46 -0000 John Hein has reassigned Bugzilla Automation 's request for maintainer-feedback to gnome@FreeBSD.o= rg: Bug 225206: devel/xdg-utils: xdg-mime has bogus patch to use stat -f https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D225206 --- Description --- Created attachment 189782 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D189782&action= =3Dedit [patch] remove incorrect stat -f patch in favor of [now] fully supported readlink -f 'stat -f ' has never been correct, but now the patch to use it instea= d of readlink -f is unnecessary. readlink -f has worked since freebsd 8, so ust remove the bogus stat -f. I think 'stat -f' was an attempt to work around the absence of '-f' for readlink in freebsd before 8.x. But it's just an invalid invocation of stat that basically winds up doing nothing as used in xdg-mime. It certainly do= es not follow all links to get the filename of the link target. One could file a bug with stat where 'stat -L -F %N ' reports the nam= e of a link (if is a sym link) instead of the link target. Maybe that's = what was originally intended as a replacement for readlink -f. But that's a separate bug and such a replacement is no longer needed for xdg-mime.