From owner-svn-src-head@FreeBSD.ORG Mon Apr 20 13:00:57 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 39E801065673; Mon, 20 Apr 2009 13:00:57 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 1303B8FC22; Mon, 20 Apr 2009 13:00:57 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [65.122.17.41]) by cyrus.watson.org (Postfix) with ESMTPS id AA55D46B17; Mon, 20 Apr 2009 09:00:56 -0400 (EDT) Date: Mon, 20 Apr 2009 14:00:56 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: John Baldwin In-Reply-To: <200904200822.17158.jhb@freebsd.org> Message-ID: References: <200904192302.n3JN2o6Z023217@svn.freebsd.org> <200904200822.17158.jhb@freebsd.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r191291 - in head: lib/libthr/thread libexec/rtld-elf/amd64 libexec/rtld-elf/arm libexec/rtld-elf/i386 libexec/rtld-elf/ia64 libexec/rtld-elf/mips libexec/rtld-elf/powerpc libexec/rtld-... X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Apr 2009 13:00:57 -0000 On Mon, 20 Apr 2009, John Baldwin wrote: >> Now that the kernel defines CACHE_LINE_SIZE in machine/param.h, use >> that definition in the custom locking code for the run-time linker >> rather than local definitions. > > Perhaps CACHE_LINE_SIZE for ia64 and sparc64 should be 128 since that is > what rtld used? I'm happy with whatever size the platform maintainers would like. I've changed ia64, sparc64, and sun4v kernel CACHE_LINE_SIZE definitions to 128, and powerpc was already 128, but left the others at 64 bytes until such time as we have some useful numbers or informat ionto suggest another choice would be better. All I'm really looking for here is a baseline constant to use, I have no particular vested interest in specific values for the constants. Robert N M Watson Computer Laboratory University of Cambridge