From owner-freebsd-bugs@FreeBSD.ORG Sun Jan 13 05:00:06 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E4D6C16A419 for ; Sun, 13 Jan 2008 05:00:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id EFD0E13C447 for ; Sun, 13 Jan 2008 05:00:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m0D506KQ049471 for ; Sun, 13 Jan 2008 05:00:06 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m0D5065x049470; Sun, 13 Jan 2008 05:00:06 GMT (envelope-from gnats) Date: Sun, 13 Jan 2008 05:00:06 GMT Message-Id: <200801130500.m0D5065x049470@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Giorgos Keramidas Cc: Subject: Re: bin/119614: regression tests for tr(1) X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Giorgos Keramidas List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Jan 2008 05:00:07 -0000 The following reply was made to PR bin/119614; it has been noted by GNATS. From: Giorgos Keramidas To: David Schultz Cc: FreeBSD-gnats-submit@freebsd.org, Diomidis Spinellis Subject: Re: bin/119614: regression tests for tr(1) Date: Sun, 13 Jan 2008 06:32:55 +0200 On 2008-01-12 22:28, David Schultz wrote: > But I'd say commit whatever tests you have, so the next time we find a > bug, it will be a one-line change for someone to add a regression test > for it. Thanks. I'll wait a bit for Diomidis to see the PR too, in case he wants to add/change something. Then in 1-2 days I'll commit the current patch. In the meantime, I'll try adding more tests for the -d / -s options. The current patch already includes a pair of tests for -d and -cd: REGRESSION_TEST(`02', `tr -d aceg < regress.in') REGRESSION_TEST(`0b', `(tr -cd "[[:xdigit:]]" < regress2.in ; echo)') I'm sure we can come up with more :) Locales shouldn't be too hard to do too, but I only have experience with the en_US.* and el_GR.* locales, so I may need a bit of help with the rest of them.