From owner-cvs-all Tue Jul 25 15:24:46 2000 Delivered-To: cvs-all@freebsd.org Received: from netplex.com.au (adsl-63-207-30-186.dsl.snfc21.pacbell.net [63.207.30.186]) by hub.freebsd.org (Postfix) with ESMTP id 4A07B37BA6B; Tue, 25 Jul 2000 15:24:38 -0700 (PDT) (envelope-from peter@netplex.com.au) Received: from netplex.com.au (peter@localhost [127.0.0.1]) by netplex.com.au (8.9.3/8.9.3) with ESMTP id PAA34677; Tue, 25 Jul 2000 15:13:02 -0700 (PDT) (envelope-from peter@netplex.com.au) Message-Id: <200007252213.PAA34677@netplex.com.au> X-Mailer: exmh version 2.1.1 10/15/1999 To: Warner Losh Cc: "Andrey A. Chernov" , "Jordan K. Hubbard" , Marcel Moolenaar , Will Andrews , Marcel Moolenaar , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc Makefile src/include Makefile src/release Makefile src/release/picobsd/build Makefile.mfs src/release/picobsd/custom Makefile.mfs src/release/picobsd/dial Makefile.mfs src/release/picobsd/install Makefile.mfs In-Reply-To: Message from Warner Losh of "Mon, 24 Jul 2000 20:28:15 MDT." <200007250228.UAA85362@harmony.village.org> Date: Tue, 25 Jul 2000 15:13:01 -0700 From: Peter Wemm Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Warner Losh wrote: [..] > Finally, the -L changes were correct. The reason that we need them > for the buildworld, but not for other uses is fairly simple. The > buildworld process requires mtree to set permissions. > > But come to think of it, I'm not at all sure why we need to have mtree > follow symbolic links in the build process. I thought I understood > that, but now cannot find the words to explain it and am in doubt of > my understanding of it. [..] Our tree as it stands today: peter@daintree[3:08pm]~src/usr.sbin/mtree-107> cvs diff -r CSRG mtree.c | grep ftsopt < int ftsoptions = FTS_PHYSICAL; > int ftsoptions = FTS_LOGICAL; This makes mtree(8) follows symlinks as if they were not there. eg: if you have SHARED=symlinks for /usr/include, then 'installworld' will chown fragments of your src/sys tree. This pisses me off a lot because I do not leave the source owned by root and do all my work as non-root. On a semi-regular basis, buildworld has chowned the src/sys tree as well, but this seems to have been fixed. IMHO, we need to restore FTS_PHYSICAL by default, as it was on 4.4BSD and as (I believe) it is on the other *BSD's. Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message