From owner-cvs-all@FreeBSD.ORG  Mon Mar 28 09:13:22 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 43C2E16A4CE; Mon, 28 Mar 2005 09:13:22 +0000 (GMT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 27FC243D41; Mon, 28 Mar 2005 09:13:22 +0000 (GMT)
	(envelope-from dougb@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j2S9DLLC024749;
	Mon, 28 Mar 2005 09:13:22 GMT
	(envelope-from dougb@repoman.freebsd.org)
Received: (from dougb@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j2S9DLIV024748;
	Mon, 28 Mar 2005 09:13:21 GMT
	(envelope-from dougb)
Message-Id: <200503280913.j2S9DLIV024748@repoman.freebsd.org>
From: Doug Barton <dougb@FreeBSD.org>
Date: Mon, 28 Mar 2005 09:13:21 +0000 (UTC)
To: ports-committers@FreeBSD.org, cvs-ports@FreeBSD.org,
	cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: ports/x11-wm/windowmaker/files patch-net_wm_icon
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Mar 2005 09:13:22 -0000

dougb       2005-03-28 09:13:21 UTC

  FreeBSD ports repository

  Added files:
    x11-wm/windowmaker/files patch-net_wm_icon 
  Log:
  Patch to fix a debilitating problem for amd64 users. To quote Scott:
  
  "While it compiles and seems to start fine, it will crash if you
  start any GTK-based program, including Firefox and Mozilla ...
  GTK populates the NET_WM_ICON X11 property with incorrectly padded
  data, and WindowMaker blindly reads it out and winds up passing
  garbage to some X libraries, which in turn abort the entire process ...
  Fortunately, handling this X11 property is not mandatory as there are
  other more reliable ways to pass icon state through X (and in fact very
  very few other window managers even try this), so it's safe to avoid the
  whole mess by stubbing it out and letting Windowmaker fall back to a
  more reliable method."
  
  I've tested this patch with i386 windowmaker, and haven't noticed any
  differences. I have xterms and various other things doing fancy stuff
  with window and icon titles, so I'm pretty confident that this will
  be safe for users of all ARCH's. It's also possible that it will help
  those users who were having weird QT problems, but I was not able to
  reproduce that problem so I can't say for sure.
  
  Submitted by:   scottl
  Approved by:    portmgr (krion)
  
  Revision  Changes    Path
  1.1       +11 -0     ports/x11-wm/windowmaker/files/patch-net_wm_icon (new)