Date: Wed, 26 Sep 2012 10:58:24 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Ed Maste <emaste@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r240938 - head/sys/net Message-ID: <20120926065824.GA50433@FreeBSD.org> In-Reply-To: <20120926065615.GZ50433@FreeBSD.org> References: <201209252210.q8PMAEx5003950@svn.freebsd.org> <20120926065615.GZ50433@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Sep 26, 2012 at 10:56:15AM +0400, Gleb Smirnoff wrote: T> Ed, T> T> On Tue, Sep 25, 2012 at 10:10:14PM +0000, Ed Maste wrote: T> E> Author: emaste T> E> Date: Tue Sep 25 22:10:14 2012 T> E> New Revision: 240938 T> E> URL: http://svn.freebsd.org/changeset/base/240938 T> E> T> E> Log: T> E> Avoid INVARIANTS panic destroying an in-use tap(4) T> E> T> E> The requirement (implied by the KASSERT in tap_destroy) that the tap is T> E> closed isn't valid; destroy_dev will block in devdrn while other threads T> E> are in d_* functions. T> E> T> E> Note: if_tun had the same issue, addressed in SVN revisions r186391, T> E> r186483 and r186497. The use of the condvar there appears to be T> E> redundant with the functionality provided by destroy_dev. T> T> So why did you add condvar to the softc? See it in diff below. Noticed later commit, sorry for noise. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120926065824.GA50433>