From owner-svn-ports-head@FreeBSD.ORG Fri May 2 16:04:09 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 50292898 for ; Fri, 2 May 2014 16:04:09 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 34EAF1AEC for ; Fri, 2 May 2014 16:04:09 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s42G48xj061898 for ; Fri, 2 May 2014 16:04:08 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s42G48R1061891 for svn-ports-head@freebsd.org; Fri, 2 May 2014 16:04:08 GMT (envelope-from bdrewery) Received: (qmail 68781 invoked from network); 2 May 2014 11:04:07 -0500 Received: from unknown (HELO roundcube.xk42.net) (10.10.5.5) by sweb.xzibition.com with SMTP; 2 May 2014 11:04:07 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 02 May 2014 11:04:07 -0500 From: Bryan Drewery To: Christoph Theis Subject: Re: svn commit: r352813 - in head/security/py-fail2ban: . files Organization: FreeBSD In-Reply-To: <5363C176.6050100@gmx.at> References: <201405021317.s42DHQ5P053302@svn.freebsd.org> <5363A968.7010707@freebsd.org> <5363C176.6050100@gmx.at> Message-ID: <7e75dcf81553538101a3fcce151cf558@shatow.net> X-Sender: bdrewery@FreeBSD.org User-Agent: Roundcube Webmail/0.9.5 Cc: svn-ports-head@freebsd.org, owner-ports-committers@freebsd.org, Andrey Chernov , svn-ports-all@freebsd.org, ports-committers@freebsd.org, Sunpoet Po-Chuan Hsieh X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 May 2014 16:04:09 -0000 On 2014-05-02 11:01, Christoph Theis wrote: > Am 02.05.2014 16:19, schrieb Andrey Chernov: >> On 02.05.2014 17:17, Sunpoet Po-Chuan Hsieh wrote: >>> - Update to 0.9.0 >> >> ${FAIL2BAN_DBDIR} is not created on install for the reason unknown. > > In my patch I had a rule > post-install: > @${MKDIR} ${FAIL2BAN_DBDIR} > > In the commit it became a > post-install: > @${MKDIR} ${STAGEDIR}${FAIL2BAN_DBDIR} > > @Hsieh: As a workaround create the /var/db/fail2ban manually > > @Andrey: My intention was to create that directory during > installation. I think it is wrong to create it in $STAGEDIR instead > during post-install. But what would be the correct way to create a > /var/db directory used at runtime only and nothing is copied there > during installation? It's not proper to create directories outside of STAGEDIR in post-install. If you want to create a directory at install time then it is now done in the plist-plist as an @exec. Something like this (untested, this is frequently problematic creating dirs outside PREFIX): @cwd / @exec install -d /var/db/fail2ban @dirrmtry /var/db/fail2ban -- Regards, Bryan Drewery