From owner-freebsd-current Tue Oct 29 4:57: 4 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 21B5E37B401; Tue, 29 Oct 2002 04:57:03 -0800 (PST) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id F309543E6E; Tue, 29 Oct 2002 04:57:00 -0800 (PST) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.6/8.12.6) with ESMTP id g9TCuirF090385; Tue, 29 Oct 2002 13:56:44 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: Juli Mallett Cc: current@FreeBSD.ORG Subject: Re: make(1) broken! In-Reply-To: Your message of "Tue, 29 Oct 2002 04:16:34 PST." <20021029041633.A96819@FreeBSD.org> Date: Tue, 29 Oct 2002 13:56:44 +0100 Message-ID: <90384.1035896204@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20021029041633.A96819@FreeBSD.org>, Juli Mallett writes: >> Please test make(1) changes on "make release" in the future. > >The standard metric has been 'make buildworld' I thought? Anyway, try >with revision 1.2 of var_modify.c, that should do it. There are a lot of weird make targets which are only used for installworld, distribute and release, so for something as omnibuggable as make(1), I would prefer if you used make release. >Realistically, to prevent any sort of breakage to make(1), we should >test make(1) by building every port that does not USE_GMAKE, and do >release, and do cross-release. Or just not modify it, except for >bugfixes, which should be tested as above. I don't think we need to go overboard, but we are in the run{up,down} to a release now, so some extra testing would be nice. Having a set of regression tests for make under src/tools/regression would be really cool as well. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message