From owner-freebsd-ports@FreeBSD.ORG Sat Apr 10 10:18:45 2010 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 24B08106564A for ; Sat, 10 Apr 2010 10:18:45 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: from mail-qy0-f181.google.com (mail-qy0-f181.google.com [209.85.221.181]) by mx1.freebsd.org (Postfix) with ESMTP id D4AC18FC14 for ; Sat, 10 Apr 2010 10:18:44 +0000 (UTC) Received: by qyk11 with SMTP id 11so3438954qyk.13 for ; Sat, 10 Apr 2010 03:18:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:received:message-id:subject:from:to:cc:content-type; bh=yxkCWJESYMNdsFjTlO5tSLHAIQkjcWNE9gWR2SnDecc=; b=F/Z6hSSfgjcXY1KVoXHtG0YdsPOcmumB4IW59dln0UdG28c1eOiNB83oXGq+uTiGVL dExekZhtbUY5SwKx4uNjiURjYmp6Wj7pWDKvHDgVfeW3P9UTya9H0qE9UFsydLRSrYqO wIY8dTVpyJ0kgiKmIDzvjIWGzlYnykbXpg9VM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=ZXpFjZACBenACsjp0IybBCtELr7ww1JqplDIKxnUwKTJpmqz2BiPN1aglk6z/GWFWi XwWo1b58z2xpNcRqIFqLGI6XgjBh5kgl7IBSUnFtTDf3wiIjF9mDHF080S+cO8eWxs8B ubp5r8d6pkYlLO/6n0Un7hiJnnQ+xMCds3ceg= MIME-Version: 1.0 Received: by 10.229.28.85 with HTTP; Sat, 10 Apr 2010 03:18:42 -0700 (PDT) In-Reply-To: <4BC04503.4000808@bsdforen.de> References: <4BC04503.4000808@bsdforen.de> Date: Sat, 10 Apr 2010 03:18:42 -0700 Received: by 10.229.236.16 with SMTP id ki16mr1629593qcb.68.1270894722411; Sat, 10 Apr 2010 03:18:42 -0700 (PDT) Message-ID: From: Garrett Cooper To: Dominic Fandrey Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-ports@freebsd.org Subject: Re: Trivial PR, fix package-noinstall X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Apr 2010 10:18:45 -0000 On Sat, Apr 10, 2010 at 2:29 AM, Dominic Fandrey wrote: > This morning I took a look at my outstanding PRs. There are > is a ports PR I consider old and trivial: > > This one fixes a bug in the package-noinstall target. wxs told > me that he prefers my proposed fix over his own: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/144164 This suggested fix completely breaks pkg_creates operation because it does a chdir(2) prior to package creation (from .../usr.sbin/pkg_install/create/perform.c:555): if (chdir(log_dir) == FAIL) { warnx("can't change directory to '%s'!", log_dir); return FALSE; } The goal is to expand use of the install and deinstall scripts, not break them in ports; this would be counterproductive to what we want to do. FWIW, I've thought this over and and user modifiable scripts should not be in packages; they should instead be example files which don't conflict with real configuration files. This is already the case for several ports, but not all ports. If we did this, it would solve the problem we've had with ports removing or overwriting user config files simply and easily. I wonder if other folks agree with me or not. Thanks, -Garrett