From owner-p4-projects@FreeBSD.ORG Tue Nov 4 21:51:25 2003 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id C920516A4D0; Tue, 4 Nov 2003 21:51:24 -0800 (PST) Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A257D16A4CE for ; Tue, 4 Nov 2003 21:51:24 -0800 (PST) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 247CF43FCB for ; Tue, 4 Nov 2003 21:51:24 -0800 (PST) (envelope-from sam@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.9/8.12.9) with ESMTP id hA55pNXJ023099 for ; Tue, 4 Nov 2003 21:51:23 -0800 (PST) (envelope-from sam@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.12.9/8.12.9/Submit) id hA55pNPW023095 for perforce@freebsd.org; Tue, 4 Nov 2003 21:51:23 -0800 (PST) (envelope-from sam@freebsd.org) Date: Tue, 4 Nov 2003 21:51:23 -0800 (PST) Message-Id: <200311050551.hA55pNPW023095@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to sam@freebsd.org using -f From: Sam Leffler To: Perforce Change Reviews Subject: PERFORCE change 41414 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Nov 2003 05:51:25 -0000 http://perforce.freebsd.org/chv.cgi?CH=41414 Change 41414 by sam@sam_ebb on 2003/11/04 21:51:21 GIANT_REQUIRED does not have a trailing () Affected files ... .. //depot/projects/netperf/sys/netatalk/ddp_input.c#4 edit .. //depot/projects/netperf/sys/netinet6/ip6_input.c#19 edit .. //depot/projects/netperf/sys/netipx/ipx_input.c#7 edit .. //depot/projects/netperf/sys/netnatm/natm.c#6 edit Differences ... ==== //depot/projects/netperf/sys/netatalk/ddp_input.c#4 (text+ko) ==== @@ -39,7 +39,7 @@ void at2intr(struct mbuf *m) { - GIANT_REQUIRED(); + GIANT_REQUIRED; /* * Phase 2 packet handling @@ -67,7 +67,7 @@ elhp = mtod(m, struct elaphdr *); m_adj(m, SZ_ELAPHDR); - GIANT_REQUIRED(); + GIANT_REQUIRED; if (elhp->el_type == ELAP_DDPEXTEND) { ddp_input(m, m->m_pkthdr.rcvif, NULL, 1); ==== //depot/projects/netperf/sys/netinet6/ip6_input.c#19 (text+ko) ==== @@ -249,7 +249,7 @@ #endif int srcrt = 0; - GIANT_REQUIRED(); /* XXX for now */ + GIANT_REQUIRED; /* XXX for now */ #ifdef IPSEC /* * should the inner packet be considered authentic? ==== //depot/projects/netperf/sys/netipx/ipx_input.c#7 (text+ko) ==== @@ -133,7 +133,7 @@ struct ipx_ifaddr *ia; int len; - GIANT_REQUIRED(); + GIANT_REQUIRED; /* * If no IPX addresses have been set yet but the interfaces ==== //depot/projects/netperf/sys/netnatm/natm.c#6 (text+ko) ==== @@ -685,7 +685,7 @@ struct socket *so; struct natmpcb *npcb; - GIANT_REQUIRED(); + GIANT_REQUIRED; #ifdef DIAGNOSTIC M_ASSERTPKTHDR(m);