From owner-freebsd-ports@FreeBSD.ORG Thu Feb 10 16:55:22 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8EC8C106566B for ; Thu, 10 Feb 2011 16:55:22 +0000 (UTC) (envelope-from kwm@rainbow-runner.nl) Received: from fep33.mx.upcmail.net (fep33.mx.upcmail.net [62.179.121.51]) by mx1.freebsd.org (Postfix) with ESMTP id D97D48FC13 for ; Thu, 10 Feb 2011 16:55:21 +0000 (UTC) Received: from edge01.upcmail.net ([192.168.13.236]) by viefep18-int.chello.at (InterMail vM.8.01.02.02 201-2260-120-106-20100312) with ESMTP id <20110210163901.BUMZ1353.viefep18-int.chello.at@edge01.upcmail.net>; Thu, 10 Feb 2011 17:39:01 +0100 Received: from [192.168.0.104] ([62.195.142.229]) by edge01.upcmail.net with edge id 6Gex1g00k4xAGFy01Gey6n; Thu, 10 Feb 2011 17:39:01 +0100 X-SourceIP: 62.195.142.229 From: Koop Mast To: arrowdodger <6yearold@gmail.com> In-Reply-To: References: <20110209161008.GD87684@bonjour.sunpoet.net> <20110210143506.GA66529@bonjour.sunpoet.net> Content-Type: text/plain; charset="UTF-8" Date: Thu, 10 Feb 2011 17:39:30 +0100 Message-ID: <1297355970.22746.4.camel@headache.rainbow-runner.nl> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit X-Cloudmark-Analysis: v=1.1 cv=tMVj8KYobzzX0EiRnC7vY2isLrCxFvdg4RrHWPZXwJ0= c=1 sm=0 a=5wFBJ9djAmoA:10 a=IkcTkHD0fZMA:10 a=6I5d2MoRAAAA:8 a=X99PldhSAAAA:8 a=OY7Yfi-d0CHQeOkad7wA:9 a=0Nv5a5tfC9kuRncSzmQA:7 a=C-UPOdFNwW0xVrOJ4ZDvCH4RhqQA:4 a=QEXdDO2ut3YA:10 a=SV7veod9ZcQA:10 a=HpAAvcLHHh0Zw7uRqdWCyQ==:117 Cc: Sunpoet Po-Chuan Hsieh , freebsd-ports@freebsd.org Subject: Re: Request for new port review: TortoiseHG. X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Feb 2011 16:55:22 -0000 On Thu, 2011-02-10 at 18:21 +0300, arrowdodger wrote: > On Thu, Feb 10, 2011 at 5:35 PM, Sunpoet Po-Chuan Hsieh > wrote: > > > On Thu, Feb 10, 2011 at 04:36:40PM +0300, arrowdodger wrote: > > > I've updated port. The only thing left - setting dependency on py-gobject > > by > > > USE_GNOME variable. > > > But if i run pkg_info -f on installed port, i see: > > > > > > > Dependency: py26-gobject-2.26.0 > > > > dependency origin: devel/py-gobject > > > > > > > So, maybe this dependency is implicit and i should not care? > > > > Obviously USE_GNOME does not support devel/py-gobject now. All you can > > do is to use BUILD_DEPENDS/RUN_DEPENDS. There is now a pygobject USE_GNOME switch. -Koop > > Your pkg_info result indicates that you've installed gobject, but it > > means nothing to users of this port. The ports infrastructure generates > > dependency list according to the Makefile. If py-gobject is required, > > add it to the corresponding *_DEPENDS explicitly. Otherwise gobject will > > not be installed. > > > > > Updated port can be obtained here: > > > http://intara.org.ru/tortoisehg1.shar > > > or from attachment. > > > > Some comments: > > - PORTNAME can be different with the path. PORTNAME=tortoisehg is OK. > > - We usually use "USE_PYTHON=yes" > > - It would be better to keep patches in *-patch: targets. > > Move "${REINPLACE_CMD}" actions to post-patch:. > > - If this port does not need to run configure or so. Use > > do-configure: > > @${DO_NADA} > > > > Regards, > > > Done. > > How should i submit new port? Open an PR? > _______________________________________________ > freebsd-ports@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-ports > To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org"