From owner-svn-src-all@FreeBSD.ORG Mon Mar 21 14:29:54 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E33FE10657DC; Mon, 21 Mar 2011 14:29:53 +0000 (UTC) (envelope-from dchagin@dchagin.static.corbina.ru) Received: from contrabass.corbina.net (contrabass.post.ru [85.21.78.5]) by mx1.freebsd.org (Postfix) with ESMTP id 5B3368FC14; Mon, 21 Mar 2011 14:29:53 +0000 (UTC) Received: from corbina.ru (mail.post.ru [195.14.50.16]) by contrabass.corbina.net (Postfix) with ESMTP id 71C82CBCD1; Mon, 21 Mar 2011 17:29:51 +0300 (MSK) X-Virus-Scanned: by cgpav Uf39PSi9pFi9oFi9 Received: from [10.208.22.99] (HELO dchagin.static.corbina.ru) by corbina.ru (CommuniGate Pro SMTP 5.1.14) with ESMTPS id 310136914; Mon, 21 Mar 2011 17:29:51 +0300 Received: from dchagin.static.corbina.ru (localhost [127.0.0.1]) by dchagin.static.corbina.ru (8.14.4/8.14.4) with ESMTP id p2LETowI006672; Mon, 21 Mar 2011 17:29:50 +0300 (MSK) (envelope-from dchagin@dchagin.static.corbina.ru) Received: (from dchagin@localhost) by dchagin.static.corbina.ru (8.14.4/8.14.4/Submit) id p2LETjKp006671; Mon, 21 Mar 2011 17:29:45 +0300 (MSK) (envelope-from dchagin) Date: Mon, 21 Mar 2011 17:29:45 +0300 From: Chagin Dmitry To: Gleb Smirnoff Message-ID: <20110321142945.GA6549@dchagin.static.corbina.ru> References: <201103200835.p2K8Z05Z049647@svn.freebsd.org> <20110321083820.GU71575@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="X1bOJ3K7DJ5YkBrT" Content-Disposition: inline In-Reply-To: <20110321083820.GU71575@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r219791 - head/sys/net X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2011 14:29:54 -0000 --X1bOJ3K7DJ5YkBrT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 21, 2011 at 11:38:20AM +0300, Gleb Smirnoff wrote: > On Sun, Mar 20, 2011 at 08:35:00AM +0000, Dmitry Chagin wrote: > D> Author: dchagin > D> Date: Sun Mar 20 08:35:00 2011 > D> New Revision: 219791 > D> URL: http://svn.freebsd.org/changeset/base/219791 > D>=20 > D> Log: > D> Remove dead code. >=20 > This wasn't a code, but defines. Removing them saves nothing, but > primitives deleted may be useful. >=20 Disagee here, trylock() is not a useful/common primitive, at least here. Others persisted from r183017 to r186119, most likely have been commited under the unknown drugs :) > D> MFC after: 1 Week > D>=20 > D> Modified: > D> head/sys/net/route.h > D>=20 > D> Modified: head/sys/net/route.h > D> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > D> --- head/sys/net/route.h Sun Mar 20 08:27:06 2011 (r219790) > D> +++ head/sys/net/route.h Sun Mar 20 08:35:00 2011 (r219791) > D> @@ -325,7 +325,6 @@ struct rt_addrinfo { > D> #define RT_LOCK_INIT(_rt) \ > D> mtx_init(&(_rt)->rt_mtx, "rtentry", NULL, MTX_DEF | MTX_DUPOK) > D> #define RT_LOCK(_rt) mtx_lock(&(_rt)->rt_mtx) > D> -#define RT_TRYLOCK(_rt) mtx_trylock(&(_rt)->rt_mtx) > D> #define RT_UNLOCK(_rt) mtx_unlock(&(_rt)->rt_mtx) > D> #define RT_LOCK_DESTROY(_rt) mtx_destroy(&(_rt)->rt_mtx) > D> #define RT_LOCK_ASSERT(_rt) mtx_assert(&(_rt)->rt_mtx, MA_OWNED) > D> @@ -360,22 +359,6 @@ struct rt_addrinfo { > D> RTFREE_LOCKED(_rt); \ > D> } while (0) > D> =20 > D> -#define RT_TEMP_UNLOCK(_rt) do { \ > D> - RT_ADDREF(_rt); \ > D> - RT_UNLOCK(_rt); \ > D> -} while (0) > D> - > D> -#define RT_RELOCK(_rt) do { \ > D> - RT_LOCK(_rt); \ > D> - if ((_rt)->rt_refcnt <=3D 1) { \ > D> - rtfree(_rt); \ > D> - _rt =3D 0; /* signal that it went away */ \ > D> - } else { \ > D> - RT_REMREF(_rt); \ > D> - /* note that _rt is still valid */ \ > D> - } \ > D> -} while (0) > D> - > D> struct radix_node_head *rt_tables_get_rnh(int, int); > D> =20 > D> struct ifmultiaddr; >=20 > --=20 > Totus tuus, Glebius. --=20 Have fun! chd --X1bOJ3K7DJ5YkBrT Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (FreeBSD) iEYEARECAAYFAk2HYNkACgkQ0t2Tb3OO/O1ThACfX+nFlt81hVtHLBzPvL8CLlKL swIAnRevYuDn8nQ+9cdc0ZgGXkmOPmSe =l14k -----END PGP SIGNATURE----- --X1bOJ3K7DJ5YkBrT--