From owner-freebsd-arch Fri Feb 22 1:15:42 2002 Delivered-To: freebsd-arch@freebsd.org Received: from mail5.speakeasy.net (mail5.speakeasy.net [216.254.0.205]) by hub.freebsd.org (Postfix) with ESMTP id AD7DB37B400 for ; Fri, 22 Feb 2002 01:15:35 -0800 (PST) Received: (qmail 13189 invoked from network); 22 Feb 2002 09:15:34 -0000 Received: from unknown (HELO laptop.baldwin.cx) ([65.91.136.163]) (envelope-sender ) by mail5.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 22 Feb 2002 09:15:34 -0000 Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200202220539.g1M5ddM13773@apollo.backplane.com> Date: Fri, 22 Feb 2002 04:15:35 -0500 (EST) From: John Baldwin To: Matthew Dillon Subject: Re: RE: that INVARIANT/ucred freeing stuff. Cc: Julian Elischer , arch@FreeBSD.org Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 22-Feb-02 Matthew Dillon wrote: >:Fine, stick it under DIAGNOSTIC (which isn't dead.) The problem is that >:there >:aren't just 5 places in the kernel that you would need to stick this assert, >:you would need it all over the place. But I guess no one else has looked at >:all the places that p_ucred is used and thought about how to ensure we don't >:use a bogus td_ucred. >: >: >:John Baldwin <>< http://www.FreeBSD.org/~jhb/ > > Don't try to overengineer the problem. Unless you believe there is > a serious problem, there is no need to put a check in every single > conceivable place an error might occur. Just putting a few safety checks > in a few critical places should be sufficient. I don't know where all the places we might look at a ucred wrongly are. That's why I wanted the much simpler solution of just clearing td_ucred to NULL so we had an implicit KASSERT for us in all those places. > -Matt > Matthew Dillon > -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message