From owner-svn-ports-head@freebsd.org Sat Mar 20 08:18:32 2021 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E8C1A5770A0; Sat, 20 Mar 2021 08:18:32 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F2YYh6GYsz3NYV; Sat, 20 Mar 2021 08:18:32 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1616228312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dAS0HWi1JaoPUZs20YPkVyWmxpMPDgs9+LwUsHHfS1A=; b=mJC7spc4064dZGTGy7NjX4CU0M3lHsabhBeBvJARsj5TioJonrYqPavweTFfrwyhSxybjI 3BmxQ6CXnpGCmZRCY+N5oHghGCeSACXHwH9KkVtkdVQ0tVOvuHhP6YnyXiLal4edyRVkPQ URZP3ZZuDFeVVkZL1fs96i0dEIrJqYMaB6JlLSflwzJKkcotQBAgDNfqcIGDn1wXwT8laA 8l0En0AqfBz4R0LcoJoctd6/J/NufBJmD2JU2GLyy0glOYCnjRS3Pi54A1bZO4zvlGlLgt gobgNr76EOm8zevuwGayPcX61/KVU6MWv67Gy2i6q4IO7WGOXjnJ2OUj91YrqQ== Received: by freefall.freebsd.org (Postfix, from userid 1033) id CBD322E69; Sat, 20 Mar 2021 08:18:32 +0000 (UTC) Date: Sat, 20 Mar 2021 08:18:32 +0000 From: Alexey Dokuchaev To: Gleb Popov Cc: ports-committers , svn-ports-all , svn-ports-head Subject: Re: svn commit: r568794 - in head/multimedia/pipewire: . files Message-ID: <20210320081832.GA21788@FreeBSD.org> References: <202103191336.12JDaj8i012572@repo.freebsd.org> <20210319174447.GA16542@FreeBSD.org> <20210320033712.GA18472@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1616228312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dAS0HWi1JaoPUZs20YPkVyWmxpMPDgs9+LwUsHHfS1A=; b=ONhYBrha9VhclcLTXi1i/nZrewJrRrW4LJY3o97A4CoKtNmhXkSrMpAgoCPAGnDM4QaOYB xVS63PbWNoUka9n/ZY+vq3gMxUj5Y3rHK0s1TQjTPflUiXqmmRH010VBf4hVeP71FU4MEG 5lh9JEEOpG2obE900qG+DxtcLfGYoW51kICrlD6vfDGvzneUpTo4YBD1SkxIRDTyalcAF9 LaclZ4VPQyelxcb3V+87adrJEnngUtSwAhznjMzyIpwyIKQcNjqb/9Fz0r+1S/n5raD2Bu 4EMg2a6cmhJr1Bwy03mbjhRmup/diMffxIfPSrsrB9w9/SGxCF0rWgDL7YXORw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1616228312; a=rsa-sha256; cv=none; b=L96OyWgr6PqMyAYocpH3Tn1VLQcMcT0W5tmkHyrJ+yU9L6PGnLFPgrFY3jAbyFUpFaBWaj BjYEn600KcYFbQR60j/od4R6gA9wzMs0BArHy+3WoxTcUZtWMAG0FVBWRlLYWhQQDWAK+A wsfH0YHxlllsRzhVKDAF5Y+r5+PmHg9KTRSZn/x2uUHjKN5bT2PXAzU1TzS/6hkqfAz3F2 h87dzeExotCl4ypW6gCqLHcUar35jy34QDRuIcJf8EjTuVQKqP0AS48xZqA5ALBBhLBQUc MjEWAxvDHXadSOSoqOdq6jhxMBXqwOSTeLcRuwa0m3QGKVg6I1Mthxm7bOgqCg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Mar 2021 08:18:33 -0000 On Sat, Mar 20, 2021 at 10:38:30AM +0300, Gleb Popov wrote: > On Sat, Mar 20, 2021 at 6:37 AM Alexey Dokuchaev wrote: > ... > > On Fri, Mar 19, 2021 at 10:16:35PM +0300, Gleb Popov wrote: > > > Exactly this. > > > > Understood. Please try to write more elaborate commit logs next time, > > so everyone could easily see what's going on, not just you or me. > > I clearly remember the case where you criticized a committer for a too > lengthy commit message. I'll try my best next time, anyways. That doesn't sound like me at all, I love elaborate commit messages (as long as they are of why-ish, not what-ish type and not merely translate the commit diff in English). I'll have to dig into my sent-mail to see what were the circumstances in that particular case. > P.S. With all these "do the repocopy!" and "bad commit message!" you're > really living up to your surname. No offence, just joking. I don't understand. There are certain bylaws and even rules of how we do things in the common repo, those practices are instated to make everyone's work easier. Waived repocopies and poor commit logs make this harder. And I'm not just complaining, I actually go and fix the mess when I see there's no interest from the original committer. Did I ever get a "thank you" back? No, I got "you're really living up to your surname" from you. We have mentoring process to teach those things to new developers. So if it happens, something went wrong and needs fixing. These are not the style and formatting bugs; by ignoring or tolerating them we'd be lowering our quality bar, and this deprives people from working on ports. It's very sad to hear when people say something like "I wanted to update/work/ improve on that port, but it's so messy, history does not explain much, so I walked away". ./danfe