From owner-freebsd-current@FreeBSD.ORG  Mon Mar 17 06:16:19 2008
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1E5A9106566B;
	Mon, 17 Mar 2008 06:16:19 +0000 (UTC)
	(envelope-from gshapiro@freebsd.org)
Received: from gir.gshapiro.net (gir.gshapiro.net [209.246.26.16])
	by mx1.freebsd.org (Postfix) with ESMTP id 09FA08FC16;
	Mon, 17 Mar 2008 06:16:18 +0000 (UTC)
	(envelope-from gshapiro@freebsd.org)
Received: from monkeyboy.local (c-67-164-3-230.hsd1.ca.comcast.net
	[67.164.3.230]) (authenticated bits=128)
	by gir.gshapiro.net (8.14.3.Alpha1/8.14.2) with ESMTP id m2H6G3Va004079
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Sun, 16 Mar 2008 23:16:13 -0700 (PDT)
	(envelope-from gshapiro@freebsd.org)
Date: Sun, 16 Mar 2008 23:15:58 -0700
From: Gregory Shapiro <gshapiro@freebsd.org>
To: Mike Telahun Makonnen <mtm@freebsd.org>
Message-ID: <20080317061558.GA1220@monkeyboy.local>
References: <20080202012707.GA1800@kobe.laptop> <1204809780.885.3.camel@sol>
	<20080306201905.GA11317@kobe.laptop>
	<20080311025333.GF2422@monkeyboy.local>
	<584bfc3f0803122336r96f4033pc0e25a7324fb0486@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <584bfc3f0803122336r96f4033pc0e25a7324fb0486@mail.gmail.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Cc: Giorgos Keramidas <keramida@ceid.upatras.gr>, current@freebsd.org
Subject: Re: latest rc.subr breaks etc/rc.d/sendmail
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Mar 2008 06:16:19 -0000

> Can you take a look at the following patch please?

The patch looks good, I just found some minor issues:

1. In /etc/rc.d/sendmail, rename sendmail_precmd to sendmail_prestart
   for consistency?

2. /etc/rc.d/sendmail-msp-queue doesn't need to set start_precmd
   or define a sendmail_prestart() function as the MSP queue runner
   doesn't use the aliases file (yes, this was a bug in the old
   /etc/rc.d/sendmail).

3. Both /etc/rc.d/sendmail-outbound and /etc/rc.d/sendmail-submit are
   missing:

   required_files="/etc/mail/sendmail.cf"

   (yes, this was also a bug in the old /etc/rc.d/sendmail).

4. Putting sendmail.subr in /etc/mail/ seems a bit odd. /etc/mail/
   is meant for MTA configuration, not startup subroutines.  Perhaps
   /etc/rc.sendmail.subr or /etc/sendmail.subr for consistency with
   /etc/network.subr?

5. This line in /etc/defaults/rc.conf:

   # Settings for /etc/rc.sendmail and /etc/rc.d/sendmail:

   should be updated to:

   # Settings for /etc/rc.sendmail and /etc/rc.d/sendmail*: