From owner-freebsd-bugs@freebsd.org Wed Oct 24 16:45:01 2018 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A8622FFC5F1 for ; Wed, 24 Oct 2018 16:45:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 36C196D948 for ; Wed, 24 Oct 2018 16:45:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id F0649FFC5F0; Wed, 24 Oct 2018 16:45:00 +0000 (UTC) Delivered-To: bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B6469FFC5EF for ; Wed, 24 Oct 2018 16:45:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 557526D947 for ; Wed, 24 Oct 2018 16:45:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 67F10B328 for ; Wed, 24 Oct 2018 16:44:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w9OGix5I054900 for ; Wed, 24 Oct 2018 16:44:59 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w9OGixdm054899 for bugs@FreeBSD.org; Wed, 24 Oct 2018 16:44:59 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 232642] sbin/ipfw show: segfault on parsing setdscp rules Date: Wed, 24 Oct 2018 16:44:59 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: sergey@akhmatov.ru X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Oct 2018 16:45:01 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D232642 Bug ID: 232642 Summary: sbin/ipfw show: segfault on parsing setdscp rules Product: Base System Version: 11.0-STABLE Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: sergey@akhmatov.ru Flags: maintainer-feedback? Created attachment 198583 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D198583&action= =3Dedit sbin/ipfw/ipfw2.c - fix ipfw show for rules with setdscp action ipfw show fails to show rules with "setdscp" action for DSCP code values without matching well-known class name. Steps to reproduce: # ipfw add 1000 setdscp 10 ip from any to any 01000 setdscp af11 ip from any to any # ipfw add 1001 setdscp 11 ip from any to any segmentation fault # ipfw show 1000 01000 0 0 setdscp af11 ip from any to any # ipfw show 1001 segmentation fault The bug was introduced in r331668. 11.2-RELEASE and 12.0-BETA1 are affected. Problem code in sbin/ipfw/ipfw2.c as follows: --- case O_SETDSCP: if (cmd->arg1 =3D=3D IP_FW_TARG) { bprintf(bp, "setdscp tablearg"); break; } s =3D match_value(f_ipdscp, cmd->arg1 & 0x3F); if (s !=3D NULL) bprintf(bp, "setdscp %s", s); else bprintf(bp, "setdscp %s", cmd->arg1 & 0x3F); --- cmd->arg1 is int, but is passed to "%s" format specifier. Changing it to "%= d" fixes things for me. --=20 You are receiving this mail because: You are the assignee for the bug.=