From owner-cvs-usrsbin  Fri May  9 22:05:28 1997
Return-Path: <owner-cvs-usrsbin>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id WAA18493
          for cvs-usrsbin-outgoing; Fri, 9 May 1997 22:05:28 -0700 (PDT)
Received: from nagual.pp.ru (ache.relcom.ru [194.58.229.133])
          by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id WAA18477;
          Fri, 9 May 1997 22:05:17 -0700 (PDT)
Received: (from ache@localhost)
	by nagual.pp.ru (8.8.5/8.8.5) id JAA02688;
	Sat, 10 May 1997 09:04:19 +0400 (MSD)
Date: Sat, 10 May 1997 09:04:15 +0400 (MSD)
From: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= <ache@nagual.pp.ru>
To: Brian Somers <brian@awfulhak.org>
cc: Bruce Evans <bde@zeta.org.au>, brian@FreeBSD.ORG, cvs-all@FreeBSD.ORG,
        CVS-committers@FreeBSD.ORG, cvs-usrsbin@FreeBSD.ORG
Subject: Re: cvs commit: src/usr.sbin/ppp timer.c 
In-Reply-To: <199705100447.FAA10327@awfulhak.demon.co.uk>
Message-ID: <Pine.BSF.3.96.970510090252.2672A-100000@nagual.pp.ru>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-usrsbin@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

On Sat, 10 May 1997, Brian Somers wrote:

> > >>   Modified:    usr.sbin/ppp  timer.c
> > >>   Log:
> > >>   Set setitimer() arg correctly.
> > >
> > >This commit not needed, read man setitimer.
> > 
> > Actually it is, read the kernel source :-).  The kernel checks the interval
> > even when it doesn't use it and fails without doing anything if the interval
> > is garbage (tv_sec < 0 || tv_sec > 10^8 || tv_usec < 0 || tv_usec >= 10^6).
> 
> Should I fix kern/kern_time.c then ?

I think that 1) kern_time.c needs fixing, 2) let timer.c code stay
as is now to be compatible with other systems possible buggy setitimer()
implementations...

-- 
Andrey A. Chernov
<ache@null.net>
http://www.nagual.pp.ru/~ache/