From owner-svn-src-all@freebsd.org Thu Jan 14 22:17:21 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0F8EEA82369 for ; Thu, 14 Jan 2016 22:17:21 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm15.bullet.mail.bf1.yahoo.com (nm15.bullet.mail.bf1.yahoo.com [98.139.212.174]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CC6711006 for ; Thu, 14 Jan 2016 22:17:20 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1452809833; bh=TmBr7ez6bUgMIx7PAjOr3wMD4j2MDYfJY782OT8tmS4=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From:Subject; b=Z8ickL0msB1ykYInxUnvJ1Qq/K8Enx9CpHByaFTHuhn7H5VQx+DgBZ7HE0oJRE339jODFLWRUSRIfSgPOGywmDi8lMBD5j6hkg0uhW0K3+FwlinaLe0og2JED8hNdRAMpvohIlW/U+MDE1tQZkOERwpkmsBN/NqjnXaoJliz9fmd2dr4pWPBkgl+TBp89MVOhjAa6CWy2QTToTq+dv8pyIO/LPL1xXXzEzjsTcOjpSCLNrQreB72pzotUdi+bweoF+Lys4STYzGySlHx6+p3BPCqNW/kHnfhCIFavkUinumZs3BYGmrRqU5yFhkJynSYWbgp9ELaZBTa/9t2yZF9mA== Received: from [98.139.170.181] by nm15.bullet.mail.bf1.yahoo.com with NNFMP; 14 Jan 2016 22:17:13 -0000 Received: from [98.139.211.195] by tm24.bullet.mail.bf1.yahoo.com with NNFMP; 14 Jan 2016 22:17:13 -0000 Received: from [127.0.0.1] by smtp204.mail.bf1.yahoo.com with NNFMP; 14 Jan 2016 22:17:13 -0000 X-Yahoo-Newman-Id: 427745.27368.bm@smtp204.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: eG01mIcVM1kIVOZZ6KCiYtp2re6bhThE1lhviediq11ZJ7P R1iKcxHqSjyGDNm_WHOxyflSi2UXU973lVzaYZy5T0W.6kCRbDSKOvg8ohs1 U1cHhNBOldkXnJgYXo0fxT56twBv_yRTHPmP1vjPB8og.CjgZozyxRFpPCac 2wQiRqL5Z8iueAfsDja6BKR9pfKDQIlg.qKLMGAKWA4o7mopUyy05HHhy5i2 BUtlh0ol9smRCdmCODXXhbXDeoN0X7wTkxqL1v40QQY7tkpaQ5ahhv.hACly YHwqkw8qDTFGOb7Z4cdkm.NvsZUPxa70mcQ80iyp0DivNIaaJ0fw6vLwXMXW 0sOTrN9H4RE5rHZzzM28GtlQYo2UmdYVULDs2_ds55Oe0AEZlUMQ6iJ5YiZQ OanEzVpAb6cnRVX.JOubzXl00pvQCvRxassOLSN_ajPT2jnxhRK68Cq6I5gV CuGyuuE3dXoSU4oDk9Fjzuyd4KESnZVn0bcwWap_15fQJUDx5pUMTHJForan FVEzdz7mV42LU_VunC5V4qweun6Pm3GZy X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r294029 - in head/sys/boot/efi: . boot1 loader To: Warner Losh References: <201601141853.u0EIrshB007863@repo.freebsd.org> <56980BAE.6070304@freebsd.org> <569812A6.9020101@freebsd.org> <5698172E.6040107@FreeBSD.org> Cc: Steven Hartland , Nathan Whitehorn , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" From: Pedro Giffuni Message-ID: <56981E73.1020101@FreeBSD.org> Date: Thu, 14 Jan 2016 17:17:23 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jan 2016 22:17:21 -0000 On 01/14/16 16:53, Warner Losh wrote: > > On Thu, Jan 14, 2016 at 2:46 PM, Pedro Giffuni > wrote: > > > > El 14/01/2016 a las 16:27, Steven Hartland escribió: > > > > On 14/01/2016 20:57, Nathan Whitehorn wrote: > > > > On 01/14/16 10:53, Steven Hartland wrote: > > Author: smh > Date: Thu Jan 14 18:53:54 2016 > New Revision: 294029 > URL: https://svnweb.freebsd.org/changeset/base/294029 > > Log: > Only build EFI components on supported compilers > As the in-tree GCC does not support > __attribute__((ms_abi)) EFI can only > be built with Clang. > The EFI loader and boot1 validated this, but > unused libefi was still built > causing issues under GCC after warnings where > enabled by r293724. > Disable building all of EFI when the selected > compiler is GCC. > > > How about with newer-than-4.2 versions of GCC? Surely this > *is* supported in newer compilers. Do we need some build > infrastructure to how about the compiler version as well as > type? > -Nathan > > > If it is then even without this change you wouldn't have have > got the EFI loader or boot1, just an unused libefi. > > This change ensures that builds with in-tree Clang and GCC build > on all platforms, even if GCC doesn't build the EFI components. > > If someone that uses none in-tree GCC has some time to dedicate > to make this work that would be great :) > > > Specially since the gcc-4.2 compiler will be axed mercilessly before > 11.0-RELEASE. > > > We hope, you mean. > As scheduled ... I mean. It was discussed in the BSDCan 2014 Dev Summit. > Never versions of gcc will be supported where they work, and will be > required for some platforms where clang isn't quite there. When we unhook the old crappy GCC someone will be forced to figure out how to get the external toolchain working. Otherwise we can sit and wait for ever. Pedro.