From owner-svn-src-all@freebsd.org Mon Feb 10 17:59:18 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 17C0023FD16 for ; Mon, 10 Feb 2020 17:59:18 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound2m.ore.mailhop.org (outbound2m.ore.mailhop.org [54.149.155.156]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48GYZF4dHWz3Jmv for ; Mon, 10 Feb 2020 17:59:17 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1581357556; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=XpdgygzP240QkPLKV97FHD9T6c9lqE0D2K7Kujx+h9bZXjSbu+TqGrngHC0O2tklQsmqTf2zswVU0 gXdBhGT7ocnOEkF8ezmLGo1SHgIifkZJ3pUp/D3pXUfZklC3glHDO/yCY63xximborwNrreISOLfZA o8d4V/KnfZE0Z6ShPnIRmb6SC/f2svX3loUawVuz1tjbK4hWrVApxhOHYXkEQWW+s3iVkYunpUej7J +byaEVcR3g/EevO2UQsHY1JirWQ+U4Xc4DIlzo/eAiAERzLxcctE9b5xPNyZ0iYvvdQziL1zLFpVhw vsskz57pQVh+Z5CbNHywAUvWcbkJShA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:dkim-signature:from; bh=wkcWr3WMXAVh2NFCswozeIQIJQOd29aRJJaTe2YvGhA=; b=T396tmptp/0ePJ/umEnfiXy3CLZVO5cXH8IxFF7owH2EPaO02hWeUFeK8vrOMjDtBMnqQ83K0Nhzn Gal6QMXEKaM8uhuM8V2X/sHC4o0cNc/aenCb+Zpe5OkVBK6QIl3XC/mRyU7YYnTO6QoRD6sDT7EFJf T6elBaOeT82lpYR4A9JWJ97SNoxds20TyqDrXRAYmU3EsXQrGXG9fz7r6JJENyYc8NBGXL6zr0TDGu 93FhWCa4KtMxLdrnTLVDhRq70N1Xvh2VNkvM9ekd2WshxqWMKUyR5v14K7uhuxkNQbnaN4Nh05MQuk GrrBDXj3qVqi2qvF/RV3rKZ6xFzYmKQ== ARC-Authentication-Results: i=1; outbound4.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:from; bh=wkcWr3WMXAVh2NFCswozeIQIJQOd29aRJJaTe2YvGhA=; b=oqowrXn9EhxTzjnGxmvaTovznTlZErjx7ZQaK84y4m//M53qldWELDlq//SzQWOWKEsoPss5mvDJy gF92yk0FhAl04ezepgZUzpkdm9LMGbozhoAMmjP7qwi9Xq9OiShO/k/+Ch/SPLFZtYXa9iLAfTCz5B BC1rpWsWPx2COBu5EDhUMjMD7lLvRYIUFLLfolLv7jfSFGvwhUYpb4RUNRWLEkSqvqjPSIc+7Xgq77 4v9NWSeCxgUdxs1evXKGLDxpMiQDYLjuIPoN2qXaoKNhGpbNEkbLQGQq+tkfSCGqVC4EnEN8Bs5PwS tsc5a1BTDPmFWgcxDGrHi9eVbtpkBYw== X-MHO-RoutePath: aGlwcGll X-MHO-User: 0c709a4f-4c2f-11ea-9eb3-25e2dfa9fa8d X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound4.ore.mailhop.org (Halon) with ESMTPSA id 0c709a4f-4c2f-11ea-9eb3-25e2dfa9fa8d; Mon, 10 Feb 2020 17:59:15 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id 01AHxEjF066793; Mon, 10 Feb 2020 10:59:14 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: Subject: Re: svn commit: r357683 - head/lib/libc/string From: Ian Lepore To: Renato Botelho , Eitan Adler , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Mon, 10 Feb 2020 10:59:14 -0700 In-Reply-To: <4729a710-65a5-0d08-bc1e-2b2d3480f0a9@FreeBSD.org> References: <202002082117.018LHmnh053114@repo.freebsd.org> <4729a710-65a5-0d08-bc1e-2b2d3480f0a9@FreeBSD.org> Content-Type: text/plain; charset="ASCII" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 48GYZF4dHWz3Jmv X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.96 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.98)[-0.979,0]; NEURAL_HAM_LONG(-0.98)[-0.979,0]; ASN(0.00)[asn:16509, ipnet:54.148.0.0/15, country:US] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Feb 2020 17:59:18 -0000 On Mon, 2020-02-10 at 10:46 -0300, Renato Botelho wrote: > On 08/02/20 18:17, Eitan Adler wrote: > > Author: eadler > > Date: Sat Feb 8 21:17:48 2020 > > New Revision: 357683 > > URL: https://svnweb.freebsd.org/changeset/base/357683 > > > > Log: > > memset.3: better fix previous typo > > > > Upon re-reading the whole sentence this is a better fix. > > > > MFC with: r357681 > > > > Modified: > > head/lib/libc/string/memset.3 > > > > Modified: head/lib/libc/string/memset.3 > > ============================================================================== > > --- head/lib/libc/string/memset.3 Sat Feb 8 21:02:20 2020 (r357682) > > +++ head/lib/libc/string/memset.3 Sat Feb 8 21:17:48 2020 (r357683) > > @@ -63,8 +63,9 @@ Undefined behaviour from > > .Fn memset , > > resulting from storage overflow, will occur if > > .Fa len > > -is greater than the length of buffer > > -.Fa dest . > > +is greater than the length of the > > +.Fa dest > > +buffer. > > The behaviour is also undefined if > > .Fa dest > > is an invalid pointer. > > .Dd should be bumped to current date > It has always been my understanding for that we don't bump .Dd for things like minor grammar and spelling fixes, only for actual content changes. A few seconds of quick googling finds mailing list messages to that effect going back many many years. -- Ian