From owner-freebsd-ports  Thu Sep 12 01:47:12 1996
Return-Path: owner-ports
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id BAA22898
          for ports-outgoing; Thu, 12 Sep 1996 01:47:12 -0700 (PDT)
Received: from relay.nuxi.com (nuxi.cs.ucdavis.edu [128.120.56.38])
          by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id BAA22891
          for <freebsd-ports@freefall.freebsd.org>; Thu, 12 Sep 1996 01:47:10 -0700 (PDT)
Received: (from obrien@localhost) by relay.nuxi.com (8.7.5/8.6.12) id BAA03410; Thu, 12 Sep 1996 01:47:31 -0700 (PDT)
From: "David E. O'Brien" <obrien@Nuxi.cs.ucdavis.edu>
Message-Id: <199609120847.BAA03410@relay.nuxi.com>
Subject: Re: port of su2
To: gurney_j@resnet.uoregon.edu
Date: Thu, 12 Sep 1996 01:47:31 -0700 (PDT)
Cc: freebsd-ports@freefall.freebsd.org
In-Reply-To: <Pine.NEB.3.95.960911181626.16787n-101000@nike.efn.org> from John-Mark Gurney at "Sep 11, 96 06:20:01 pm"
X-PGP-Fingerprint: B7 4D 3E E9 11 39 5F A3  90 76 5D 69 58 D9 98 7A
X-Pgp-Keyid: 34F9F9D5
X-Mailer: ELM [version 2.4ME+ PL22 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-ports@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

> this program has not gone through extensive testing...  but it seems to
> work fine...  someone might want to review the patches...  but they seem
> to work fine...  hope this helps... ttyl...

PLEASE read the handbook for how to make a FreeBSD port.  I would also
suggest you get almost any existing port and follow its example.  Also,
take a glance at /usr/share/mk/bsd.port.mk.  It is *very* readable as
makefiles go.

1)  Your su2/Makefile does not quite follow the FreeBSD style:
    # New ports collection makefile for:    figlet
    # Version required:     2.1.1
    # Date created:         Sat July 20, 1996
    # Whom:                 David O'Brien (obrien@cs.ucdavis.edu)
    #
    # $Id$
    #
    ...
    CATEGORIES+=	sysutils
2)  su2/work/su2-1.3/Makefile does *NOT* pay attention to $(PREFIX).  Change
    $(DEST) to $(PREFIX) and this problem will be solved.  (the purpose
    of ${PREFIX} is to allow people to easly install the program
    somewhere else other than /usr/local/).
3)  You don't strip the su2 binary (add ``-s'' to the su2 install line in
    su2/work/su2-1.3/Makefile).
4)  You don't compress the man page.
    post-install:
    .if !defined{NOMANCOMPRESS}
	    gzip -9nf ${PREFIX}/man/man1/su2.1
    .endif

> Live in Peace, destroy Micro$oft, support free software, run FreeBSD (unix)

Agreed!  :-)

-- David    (obrien@nuxi.com)