From nobody Sun Aug 2 19:55:42 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hCrC26L5Hz4TM02 for ; Sun, 02 Aug 2026 19:55:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hCrC254DXz3cnd for ; Sun, 02 Aug 2026 19:55:42 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785700542; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=e+m59wdScklfrLCxL2nVLwqCLEzF+n6UGUbPYnFSMmI=; b=AKf6nZNv+Rpl4bBo0hKw4QIAwAX8jA8oCsaGcr30OWZkyp2CcAD76f0Cx8jaSuGomhkKoZ 4duui/a9VdnHGwDBfl44o/XBpDRBIdiMsrAQ61LFGBpvok/F2/ievsbgJszqwZEfTPCcdB wFm2+yQDeb53P+YUUZyhcB/6WcbfpyNyk7llCoqvYEgJptr+MgCDxLbtL+kj1KELrgTtMk G8sLIdLGuliW6bUv/Eu6XwPD9RUiNZpwcRClQh0qas/nyKUJElqpcI4uLoEexb+fNoeEYs 6QHFCaszG0KQLHcEIj+nhf0+vLy89MoXS/Y2x1xSrhplMSOsyF1qMIBZb3cDlg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785700542; a=rsa-sha256; cv=none; b=wifxLplqcd8Ne4/ipXxYMR5SaceLLYDon0YkKRDtUxfSzG7QZoxBAkWxd5w4utU1cx69Y5 5l+vYeJ24V2h/B/W9HK41Q7pS6KbYuSwC2procvuaZioNW3gK0qgTibic6FyOuMCvCwzVZ ciViV63AJm43o5ah44HrOPBzUEwVz/iiyEtfhKxEsQ8I9qg302lNj2ul1L4Th/Dk752lSb uiIkiT7w9mGBMxWRmAQ6rYsVWjeR4Hq0+hphPyjdgECNB0yHJ9zjZj1B1IsNgZPg7VJoiJ E7ED1BngRsAy2fpzjc+M4YvTxJmte+Pa3tkWPeJOLwnSNWSKP6vBsVv2U4Wejg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785700542; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=e+m59wdScklfrLCxL2nVLwqCLEzF+n6UGUbPYnFSMmI=; b=ciSPrwynDCUWwgA8N5Lu8pTqanq4TGQHW28NTNh5WwWDgONfQO4H76PrQcyz6JHvHooZr2 90Y7fHcdXajj5jNGmQ52CbTPUirnNTlh6tpUyDryGdfu4VEyCuRzLlUIHtPcWtUqCGRz4P sKeTHToJZDZ30pW3PLsfwPLbuXAkeh4IO4KLChcLWFtPw2X1sV+QTqzlbsx2pbSMKedDrS NaPTjmTrmQ33huWs3j4P+2ZDcacX3H8vUliOThZQuXbm1WKtkMEqjEURP+jV8RU6rZr1WP AlvwzoERl9u8vOS5kyScRYzHcTYxI7TUEKwQxRWbRkHs2YG0dMaur80IdyDU6w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hCrC22wFhzD15 for ; Sun, 02 Aug 2026 19:55:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 27727 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 02 Aug 2026 19:55:42 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Mark Johnston From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: 21101f52147e - stable/15 - libfetch: Fix handling of connection failures List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 21101f52147ed077350c1d3a489007c02887eb0d Auto-Submitted: auto-generated Date: Sun, 02 Aug 2026 19:55:42 +0000 Message-Id: <6a6fa0be.27727.7adbfc0b@gitrepo.freebsd.org> The branch stable/15 has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=21101f52147ed077350c1d3a489007c02887eb0d commit 21101f52147ed077350c1d3a489007c02887eb0d Author: Mark Johnston AuthorDate: 2026-07-27 18:58:34 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-08-02 19:54:45 +0000 libfetch: Fix handling of connection failures After commit 848f360c8f9a, if one tries to connect to a closed port, fetch reports "Operation now in progress", which is rather confusing. Return a more useful error message, restoring the old behaviour. Fixes: 848f360c8f9a ("libfetch: Apply timeout to connection attempts") Reviewed by: des MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D58481 (cherry picked from commit b02e02958dad2d5ce3675cbc18b9a94635d09e66) --- lib/libfetch/common.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/libfetch/common.c b/lib/libfetch/common.c index dabc8c4b16b3..8ae51d37481b 100644 --- a/lib/libfetch/common.c +++ b/lib/libfetch/common.c @@ -681,6 +681,10 @@ fetch_connect(const char *host, int port, int af, int verbose) delta.tv_usec / 1000; } } + if (pfd.revents & POLLHUP) { + errno = ECONNREFUSED; + break; + } if (pfd.revents == POLLOUT) { /* connection established */ err = 0;