From owner-freebsd-current@FreeBSD.ORG  Sat May 28 12:41:52 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1233)
	id D2B061065673; Sat, 28 May 2011 12:41:52 +0000 (UTC)
Date: Sat, 28 May 2011 12:41:52 +0000
From: Alexander Best <arundel@freebsd.org>
To: Sergey Kandaurov <pluknet@gmail.com>
Message-ID: <20110528124152.GA38130@freebsd.org>
References: <201105271046.30379.jhb@freebsd.org>
	<BANLkTin5BjXxH-PmzsW+nOpyYXEjvqJM0w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <BANLkTin5BjXxH-PmzsW+nOpyYXEjvqJM0w@mail.gmail.com>
Cc: current@freebsd.org
Subject: Re: [PATCH] Toggle display of the kernel idle process (per-CPU idle
	threads) in top
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 28 May 2011 12:41:52 -0000

On Fri May 27 11, Sergey Kandaurov wrote:
> On 27 May 2011 18:46, John Baldwin <jhb@freebsd.org> wrote:
> > Some times in top, I don't want to see all the per-CPU idle threads but
> > instead focus on the non-idle threads that are running.  Especially on a
> > system with a lot of CPUs, the idle threads can push all the interesting
> > threads off of the list.  This patch adds a new 'z' flag (gratuitously chosen
> > letter) and interactive command to toggle the display of the system idle
> > process.  Patch is tested against 8, but should work fine on HEAD too:
> 
> Works on HEAD as well. I like this idea.

works well for me, too. another thing i'd love to see is the -P flag becomming
interactive. also i think the -H option should really be documented along with
the other flags. i've seen quite a lot of people not finding the right section.
documenting a flag after the BUGS section is really non intuitive, no matter,
if the -H flag is freebsd specific or not. it should really be added to the
OPTIONS and INTERACTIVE MODE sections.

cheers.
alex

> Perhaps it could be combined with i key?
> 
> > @@ -1075,7 +1081,13 @@
> >                                reset_display();
> >                                putchar('\r');
> >                                break;
> > -
> > +                           case CMD_kidletog:
> > +                               ps.kidle = !ps.kidle;
> > +                               new_message(MT_standout | MT_delayed,
> > +                                   " %sisplaying kernel idle process.",
> 
> > +                                   ps.idle ? "D" : "Not d");
> ^^
> typo: s/idle/kidle/
> 
> 
> -- 
> wbr,
> pluknet

-- 
a13x