From owner-cvs-all@FreeBSD.ORG  Tue Aug 23 02:08:38 2011
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id C2BF51065673; Tue, 23 Aug 2011 02:08:38 +0000 (UTC)
Date: Tue, 23 Aug 2011 02:08:38 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Pawel Pekala <pawel@FreeBSD.org>
Message-ID: <20110823020838.GA96726@FreeBSD.org>
References: <201108221821.p7MILBln038468@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <201108221821.p7MILBln038468@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/polish/kadu Makefile distinfo pkg-descr
	pkg-plist ports/polish/kadu/files patch-kadu-core__CMakeLists.txt
	patch-kadu-core_gadu_resolver.cpp
	patch-modules__docking__CMakeLists.txt
	patch-modules__idle__CMakeLists.txt
	patch-modules__kde_notify__CMakeLists.txt
	patch-modules__screenshot__CMakeLists.txt
	patch-modules__sound__CMakeLists.txt ...
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Aug 2011 02:08:38 -0000

On Mon, Aug 22, 2011 at 06:21:11PM +0000, Pawel Pekala wrote:
> pawel       2011-08-22 18:21:11 UTC
> 
>   Log:
>   - unbreak and update to version 0.9.2
>   - add LICENSE info
>   - mark MAKE_JOBS_UNSAFE
>   - remove WITH_TABS option, now included in main package
>   - take maintainership

Still some issues with this port:

- First part of the makefile (delarative one) is badly indented; indentation
  should be reduced my one tabstop

- Bad spelling of Qt toolkit in COMMENT (it looks like port is QuickTime
  based now); also, " / " does not look too good, simple "and" would look
  better

%%%
 LIB_DEPENDS=		enchant.1:${PORTSDIR}/textproc/enchant \
 			gadu.3:${PORTSDIR}/polish/libgadu \
+			idn:${PORTSDIR}/dns/libidn \
 			qca.2:${PORTSDIR}/devel/qca \
 			sndfile.1:${PORTSDIR}/audio/libsndfile
%%%

Missing shlib version (notice that other libs have it).  While it
technically not required, it's nice to have to be able to grep for when
buming port revision of library consumer ports to chase shlib version
bumps.

./danfe