Date: Tue, 23 Aug 2011 02:08:38 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Pawel Pekala <pawel@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/polish/kadu Makefile distinfo pkg-descr pkg-plist ports/polish/kadu/files patch-kadu-core__CMakeLists.txt patch-kadu-core_gadu_resolver.cpp patch-modules__docking__CMakeLists.txt patch-modules__idle__CMakeLists.txt patch-modules__kde_notify__CMakeLists.txt patch-modules__screenshot__CMakeLists.txt patch-modules__sound__CMakeLists.txt ... Message-ID: <20110823020838.GA96726@FreeBSD.org> In-Reply-To: <201108221821.p7MILBln038468@repoman.freebsd.org> References: <201108221821.p7MILBln038468@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Aug 22, 2011 at 06:21:11PM +0000, Pawel Pekala wrote:
> pawel 2011-08-22 18:21:11 UTC
>
> Log:
> - unbreak and update to version 0.9.2
> - add LICENSE info
> - mark MAKE_JOBS_UNSAFE
> - remove WITH_TABS option, now included in main package
> - take maintainership
Still some issues with this port:
- First part of the makefile (delarative one) is badly indented; indentation
should be reduced my one tabstop
- Bad spelling of Qt toolkit in COMMENT (it looks like port is QuickTime
based now); also, " / " does not look too good, simple "and" would look
better
%%%
LIB_DEPENDS= enchant.1:${PORTSDIR}/textproc/enchant \
gadu.3:${PORTSDIR}/polish/libgadu \
+ idn:${PORTSDIR}/dns/libidn \
qca.2:${PORTSDIR}/devel/qca \
sndfile.1:${PORTSDIR}/audio/libsndfile
%%%
Missing shlib version (notice that other libs have it). While it
technically not required, it's nice to have to be able to grep for when
buming port revision of library consumer ports to chase shlib version
bumps.
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110823020838.GA96726>