From owner-freebsd-net@FreeBSD.ORG Sun Jul 3 00:09:03 2005 Return-Path: X-Original-To: freebsd-net@freebsd.org Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 82CE316A421; Sun, 3 Jul 2005 00:09:03 +0000 (GMT) (envelope-from ps@mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id B1C6D43D72; Sun, 3 Jul 2005 00:08:07 +0000 (GMT) (envelope-from ps@mu.org) Received: by elvis.mu.org (Postfix, from userid 1000) id 424FE5DB40; Sat, 2 Jul 2005 17:07:46 -0700 (PDT) X-Original-To: ps@mu.org Delivered-To: ps@mu.org Received: from mx2.freebsd.org (mx2.freebsd.org [216.136.204.119]) by elvis.mu.org (Postfix) with ESMTP id 24F5E5C98F for ; Thu, 11 Nov 2004 13:55:58 -0800 (PST) Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18]) by mx2.freebsd.org (Postfix) with ESMTP id EF561554C3; Thu, 11 Nov 2004 21:55:42 +0000 (GMT) (envelope-from owner-freebsd-arch@freebsd.org) Received: from hub.freebsd.org (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id 6E7DC16A4DF; Thu, 11 Nov 2004 21:55:10 +0000 (GMT) Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ADC5516A4CE; Thu, 11 Nov 2004 21:55:08 +0000 (GMT) Received: from acampi.inet.it (acampi.inet.it [213.92.1.165]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6DB1243D1D; Thu, 11 Nov 2004 21:55:08 +0000 (GMT) (envelope-from andrea@acampi.inet.it) Received: by acampi.inet.it (Postfix, from userid 1000) id DDF68F; Thu, 11 Nov 2004 22:55:06 +0100 (CET) From: Andrea Campi To: Max Laier Message-ID: <20041111215506.GA60227@webcom.it> References: <200411112124.12616.max@love2party.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200411112124.12616.max@love2party.net> User-Agent: Mutt/1.5.6i X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Sender: owner-freebsd-arch@freebsd.org Errors-To: owner-freebsd-arch@freebsd.org X-Spam-Checker-Version: SpamAssassin 3.0.0 (2004-09-13) on elvis.mu.org X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=ham version=3.0.0 X-Spam-Level: Cc: freebsd-net@freebsd.org, freebsd-arch@freebsd.org Subject: Re: in.c autoadding prefix route X-BeenThere: freebsd-net@freebsd.org List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Sun, 03 Jul 2005 00:09:03 -0000 X-Original-Date: Thu, 11 Nov 2004 22:55:06 +0100 X-List-Received-Date: Sun, 03 Jul 2005 00:09:03 -0000 On Thu, Nov 11, 2004 at 09:24:05PM +0100, Max Laier wrote: > The attached patch (http://people.freebsd.org/~mlaier/in.c.patch) derived from > WIDE via OpenBSD in.c, rev 1.21 improves the handling of automatic prefix > routes. Sounds like a very useful change indeed. One comment though: > @@ -743,26 +766,7 @@ > return (0); > flags |= RTF_HOST; > } > - > - /*- > - * Don't add host routes for interface addresses of > - * 0.0.0.0 --> 0.255.255.255 netmask 255.0.0.0. This makes it > - * possible to assign several such address pairs with consistent > - * results (no host route) and is required by BOOTP. > - * > - * XXX: This is ugly ! There should be a way for the caller to > - * say that they don't want a host route. > - */ > - if (ia->ia_addr.sin_addr.s_addr != INADDR_ANY || > - ia->ia_netmask != IN_CLASSA_NET || > - ia->ia_dstaddr.sin_addr.s_addr != htonl(IN_CLASSA_HOST)) { > - if ((error = rtinit(&ia->ia_ifa, (int)RTM_ADD, flags)) != 0) { > - ia->ia_addr = oldaddr; > - return (error); > - } > - ia->ia_flags |= IFA_ROUTE; > - } > - > + error = in_addprefix(ia, flags); > /* > * If the interface supports multicast, join the "all hosts" > * multicast group on that interface. Are you sure you want to go on if you got an error? Regardless, you should probably have an empty line after in_addrprefix. > + TAILQ_FOREACH(ia, &in_ifaddrhead, ia_link) { > + if (rtinitflags(ia)) > + p = ia->ia_dstaddr.sin_addr; > + else { The if() is misindented. The rest looks good. Bye, Andrea -- ...and that is how we know the Earth to be banana-shaped. _______________________________________________ freebsd-arch@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-arch To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org"