From owner-freebsd-current@FreeBSD.ORG Sun Nov 13 16:47:19 2011 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4AA641065670; Sun, 13 Nov 2011 16:47:19 +0000 (UTC) (envelope-from dumbbell@FreeBSD.org) Received: from mail.made4.biz (unknown [IPv6:2001:41d0:1:7018::1:3]) by mx1.freebsd.org (Postfix) with ESMTP id DA2078FC0C; Sun, 13 Nov 2011 16:47:18 +0000 (UTC) Received: from [2a01:e35:2439:2440:290:f5ff:fe9d:b78c] (helo=magellan.dumbbell.fr) by mail.made4.biz with esmtpsa (TLSv1:DHE-RSA-CAMELLIA256-SHA:256) (Exim 4.76 (FreeBSD)) (envelope-from ) id 1RPdDB-000OpX-Dq; Sun, 13 Nov 2011 17:47:18 +0100 Message-ID: <4EBFF494.2030501@FreeBSD.org> Date: Sun, 13 Nov 2011 17:47:16 +0100 From: =?UTF-8?B?SmVhbi1Tw6liYXN0aWVuIFDDqWRyb24=?= User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:8.0) Gecko/20111112 Thunderbird/8.0 MIME-Version: 1.0 To: "Andrey V. Elsukov" References: <4EBE99A7.90500@FreeBSD.org> <4EBED0A5.5070308@FreeBSD.org> In-Reply-To: <4EBED0A5.5070308@FreeBSD.org> X-Enigmail-Version: undefined Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: freebsd-current@FreeBSD.org Subject: Re: [Call for reviews] Support domain-search option in dhclient(8) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Nov 2011 16:47:19 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 12.11.2011 21:01, Andrey V. Elsukov wrote: > I have several questions after a quick view of your patch: 1. > AFAIR, our dhclient was doing changes in the system configuration > via dhclient-script, but i don't see that your changes touched it. Yes, I forgot to include this in the patch. Here's a new version: http://people.freebsd.org/~dumbbell/dhclient/dhclient-domain-search-b.patch > 2. Your code handles compressed options. It's good. But it seems > you don't check names correctness. There were some checks for > "domain-name" option, probably you can use them. This is a nice suggestion. I added it in the new version. > 3. Also it would be good to update man pages :) Also fixed in the new patch. Thank you Andrey for your feedback! - -- Jean-Sébastien Pédron -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk6/9JQACgkQa+xGJsFYOlNbzQCgnlpv8iEPsHlYmJXlBmFrD/CU 0pMAoLYrbwmtbnL9mmU3vIRgaP3bd0N2 =ykon -----END PGP SIGNATURE-----