From owner-svn-ports-all@FreeBSD.ORG  Sat Oct 19 16:10:54 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 92A297D5;
 Sat, 19 Oct 2013 16:10:54 +0000 (UTC)
 (envelope-from tijl@freebsd.org)
Received: from mailrelay001.isp.belgacom.be (mailrelay001.isp.belgacom.be
 [195.238.6.51]) by mx1.freebsd.org (Postfix) with ESMTP id 736912223;
 Sat, 19 Oct 2013 16:10:52 +0000 (UTC)
X-Belgacom-Dynamic: yes
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AoAGAHmtYlJbsUOq/2dsb2JhbABagwc4SK0hkRuBIxd0giUBAQU6HCMQCw4GBAklDyoeBgGIHAEIwB2PXAeEKQOYCIEwkFiDJjo
Received: from 170.67-177-91.adsl-dyn.isp.belgacom.be (HELO
 kalimero.tijl.coosemans.org) ([91.177.67.170])
 by relay.skynet.be with ESMTP; 19 Oct 2013 18:09:43 +0200
Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org
 [127.0.0.1])
 by kalimero.tijl.coosemans.org (8.14.7/8.14.7) with ESMTP id r9JG9gMt034266;
 Sat, 19 Oct 2013 18:09:42 +0200 (CEST)
 (envelope-from tijl@FreeBSD.org)
Date: Sat, 19 Oct 2013 18:09:42 +0200
From: Tijl Coosemans <tijl@FreeBSD.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>, Danilo Egea Gondolfo
 <danilo@FreeBSD.org>
Subject: Re: svn commit: r330645 - head/audio/audacity
Message-ID: <20131019180942.09929707@kalimero.tijl.coosemans.org>
In-Reply-To: <20131019113111.GA78540@FreeBSD.org>
References: <201310171430.r9HEUJZY033529@svn.freebsd.org>
 <20131017171050.2ce0ae53@kalimero.tijl.coosemans.org>
 <20131019113111.GA78540@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 19 Oct 2013 16:10:54 -0000

On Sat, 19 Oct 2013 11:31:11 +0000 Alexey Dokuchaev wrote:
> On Thu, Oct 17, 2013 at 05:10:50PM +0200, Tijl Coosemans wrote:
>> On Thu, 17 Oct 2013 14:30:19 +0000 (UTC) Danilo Egea Gondolfo wrote:
>>> Author: danilo
>>> Date: Thu Oct 17 14:30:19 2013
>>> New Revision: 330645
>>> URL: http://svnweb.freebsd.org/changeset/ports/330645
>>> 
>>> Log:
>>>   - Disable SSE if the arch is powerpc [1]
>>>
>>> +.if ${ARCH} == "i386" || ${ARCH} == "powerpc"
>>> +SSE_CFLAGS=	-mno-sse -mno-sse2
>>>  .endif
>> 
>> If this is a problem on powerpc it's probably also a problem on arm,
>> mips, and so on, so maybe it's better to test for ${ARCH} != "amd64"
> 
> Wouldn't checking for MACHINE_CPU:Msse(2) suffice and make eveyone happy?
> SSE are not -specific.

I looked into why the port is trying to use SSE on PowerPC and it looks
like there's a bug in the Makefile: SSE_CONFIGURE_WITH=sse should be
SSE_CONFIGURE_ENABLE=sse.  And "SSE" should be moved from OPTIONS_DEFAULT
to OPTIONS_DEFAULT_amd64.  Then you can remove SSE_CFLAGS everywhere.

The question is if this should be an option at all.  I think it's ok to
just enable SSE on all CPUs that support it like this:

.if ${MACHINE_CPU:Msse}
CONFIGURE_ARGS+=	--enable-sse
.else
CONFIGURE_ARGS+=	--disable-sse
.endif