From owner-svn-ports-all@freebsd.org Fri Apr 27 19:06:39 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6639FFAFF00; Fri, 27 Apr 2018 19:06:39 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 14BC282C28; Fri, 27 Apr 2018 19:06:39 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1354) id 0D5331D614; Fri, 27 Apr 2018 19:06:39 +0000 (UTC) From: Jan Beich To: Michael Reifenberger Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r468281 - in head/cad/openscad-devel: . files References: <201804251629.w3PGTA54028076@repo.freebsd.org> Date: Fri, 27 Apr 2018 21:06:31 +0200 In-Reply-To: <201804251629.w3PGTA54028076@repo.freebsd.org> (Michael Reifenberger's message of "Wed, 25 Apr 2018 16:29:10 +0000 (UTC)") Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2018 19:06:39 -0000 Michael Reifenberger writes: > @@ -14,6 +14,8 @@ COMMENT= Programmer's solid 3D CAD modeller > LICENSE= GPLv2+ > LICENSE_FILE= ${WRKSRC}/COPYING > > +BROKEN_FreeBSD_10= Missing __cxa_thread_atexit FreeBSD 10.4 does have __cxa_thread_atexit. 10.3 reaches EOL on 2018-04-30. https://svnweb.freebsd.org/changeset/base/304527 https://www.freebsd.org/security/#sup > QMAKE_ARGS+= VERSION=${PORTVERSION} \ > + EXPERIMENTAL=yes \ [...] > -@@ -106,4 +106,8 @@ > +--- openscad.pro.orig 2018-04-19 22:08:08 UTC > ++++ openscad.pro > +@@ -1,3 +1,4 @@ > ++CONFIG+=experimental Why not pass as QMAKE_ARGS+=CONFIG+="experimental" via port's Makefile ? 10.4 i386 build log: https://ptpb.pw/QemG --- cad/openscad-devel/Makefile~ +++ cad/openscad-devel/Makefile @@ -10,12 +10,11 @@ DIST_SUBDIR= ${PORTNAME} MAINTAINER= mr@FreeBSD.org COMMENT= Programmer's solid 3D CAD modeller +#' <-- for syntax highlighting LICENSE= GPLv2+ LICENSE_FILE= ${WRKSRC}/COPYING -BROKEN_FreeBSD_10= Missing __cxa_thread_atexit - BUILD_DEPENDS= ${LOCALBASE}/bin/flex:textproc/flex \ ${LOCALBASE}/include/boost/tuple/tuple.hpp:devel/boost-libs LIB_DEPENDS= libgmp.so:math/gmp \ @@ -41,7 +40,7 @@ USE_QT4= corelib gui opengl moc_build uic_build rcc_build PLIST_SUB= PORTVERSION=${PORTVERSION} QMAKE_ENV= EIGENDIR=${LOCALBASE}/include/eigen3 QMAKE_ARGS+= VERSION=${PORTVERSION} \ - EXPERIMENTAL=yes \ + CONFIG+="experimental" \ QMAKE_LEX=${LOCALBASE}/bin/flex \ QMAKE_YAC=${LOCALBASE}/bin/bison @@ -49,4 +48,10 @@ post-patch: @${REINPLACE_CMD} -e 's,share/man,man,' \ ${WRKSRC}/openscad.pro +.include + +.if ${OPSYS} == FreeBSD && ${OSVERSION} < 1003506 +BROKEN= no __cxa_thread_atexit() support in FreeBSD libc < 10.4 +.endif + .include diff --git cad/openscad-devel/files/patch-openscad.pro cad/openscad-devel/files/patch-openscad.pro index e261d4978ac7..f764f845f1fa 100644 --- cad/openscad-devel/files/patch-openscad.pro +++ cad/openscad-devel/files/patch-openscad.pro @@ -1,10 +1,5 @@ --- openscad.pro.orig 2018-04-19 22:08:08 UTC +++ openscad.pro -@@ -1,3 +1,4 @@ -+CONFIG+=experimental - # Environment variables which can be set to specify library locations: - # MPIRDIR - # MPFRDIR @@ -105,6 +106,10 @@ mingw* { CONFIG += qt QT += widgets concurrent