From owner-freebsd-net@FreeBSD.ORG Fri Feb 22 22:04:14 2008 Return-Path: Delivered-To: freebsd-net@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E1A3816A404 for ; Fri, 22 Feb 2008 22:04:14 +0000 (UTC) (envelope-from bms@FreeBSD.org) Received: from out3.smtp.messagingengine.com (out3.smtp.messagingengine.com [66.111.4.27]) by mx1.freebsd.org (Postfix) with ESMTP id C4C3913C45A for ; Fri, 22 Feb 2008 22:04:14 +0000 (UTC) (envelope-from bms@FreeBSD.org) Received: from compute2.internal (compute2.internal [10.202.2.42]) by out1.messagingengine.com (Postfix) with ESMTP id 4716A97FAF for ; Fri, 22 Feb 2008 17:04:14 -0500 (EST) Received: from heartbeat1.messagingengine.com ([10.202.2.160]) by compute2.internal (MEProxy); Fri, 22 Feb 2008 17:04:14 -0500 X-Sasl-enc: 3Pu57lB3caeJ0Rd79tjSq/4BPvfHDEkp8DHYmZLqiv2N 1203717854 Received: from empiric.lon.incunabulum.net (82-35-112-254.cable.ubr07.dals.blueyonder.co.uk [82.35.112.254]) by mail.messagingengine.com (Postfix) with ESMTPSA id E317645BF for ; Fri, 22 Feb 2008 17:04:13 -0500 (EST) Message-ID: <47BF46DC.6030700@FreeBSD.org> Date: Fri, 22 Feb 2008 22:04:12 +0000 From: "Bruce M. Simpson" User-Agent: Thunderbird 2.0.0.9 (X11/20080207) MIME-Version: 1.0 To: freebsd-net@FreeBSD.org References: <200802222124.m1MLO7qq012802@freefall.freebsd.org> In-Reply-To: <200802222124.m1MLO7qq012802@freefall.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Subject: Re: kern/120958: no response to ICMP traffic on interface configured with a link-local address X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Feb 2008 22:04:15 -0000 I looked at this very briefly. It's gnarly because in_canforward() is a candidate for inlining and is a predicate which is being overloaded with different meanings by ip_forward()/ip_input() and icmp_reflect(). So whilst the fix is most likely a 3 liner, it risks making the code look crap. We genuinely don't want to forward 169.254.0.0/16 traffic, however we genuinely need to reply to ICMP which originates from these ranges. bms@FreeBSD.org wrote: > Synopsis: no response to ICMP traffic on interface configured with a link-local address > > Responsible-Changed-From-To: bms->freebsd-net > Responsible-Changed-By: bms > Responsible-Changed-When: Fri 22 Feb 2008 21:23:23 UTC > Responsible-Changed-Why: > The secretary disavows all knowledge of your actions. > ["Responsible" implies "I'll fix it", I said no such thing.. I *MIGHT* > get around to it, but "Responsible" implies there's an obligation. > Cheeky linimon!] > > http://www.freebsd.org/cgi/query-pr.cgi?pr=120958 >