From owner-freebsd-bugs@freebsd.org Wed Oct 21 20:04:16 2015 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3D543A1B114 for ; Wed, 21 Oct 2015 20:04:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 103531451 for ; Wed, 21 Oct 2015 20:04:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id t9LK4Fto053693 for ; Wed, 21 Oct 2015 20:04:15 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 203943] makefs: Coverity CID 977469: False positive Date: Wed, 21 Oct 2015 20:04:16 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: scdbackup@gmx.net X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Oct 2015 20:04:16 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203943 Bug ID: 203943 Summary: makefs: Coverity CID 977469: False positive Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: scdbackup@gmx.net usr.sbin/makefs/cd9660/cd9660_debug.c CID 977469: Out-of-bounds access (OVERRUN) 1. overrun-buffer-val: Overrunning array pttemp->parent_number of 2 bytes by passing it to a function which accesses it at byte offset 3. 186 printf("%i\n", 187 debug_get_encoded_number(pttemp->parent_number,mode)); --------------- Source analysis: The problem is with debug_get_encoded_number() which depending on iparameter "mode" reads more or less bytes. The complained call is in function debug_dump_to_xml_ptentry(), which gets called only by function debug_dump_to_xml_path_table(). It gets the "mode" value as parameter. This function gets called at two occasions in debug_dump_to_xml(): debug_dump_to_xml_path_table(fd, t, t2, 721); debug_dump_to_xml_path_table(fd, t, t2, 722); The modes 721 and 722 select 2-byte reading in debug_get_encoded_number(). So the size of pttemp->parent_number is sufficient. --------------- Remedy proposal: In Coverity classify CID 977469 as "False positive" and set its Action to "Ignore". -- You are receiving this mail because: You are the assignee for the bug.