From owner-svn-src-all@FreeBSD.ORG Mon Apr 19 16:36:59 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BD8AF1065676; Mon, 19 Apr 2010 16:36:59 +0000 (UTC) (envelope-from luigi@onelab2.iet.unipi.it) Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.59.238]) by mx1.freebsd.org (Postfix) with ESMTP id 7B4598FC28; Mon, 19 Apr 2010 16:36:59 +0000 (UTC) Received: by onelab2.iet.unipi.it (Postfix, from userid 275) id 671F073098; Mon, 19 Apr 2010 18:47:32 +0200 (CEST) Date: Mon, 19 Apr 2010 18:47:32 +0200 From: Luigi Rizzo To: Robert Noland Message-ID: <20100419164732.GA51318@onelab2.iet.unipi.it> References: <201004191511.o3JFBjLj036350@svn.freebsd.org> <4BCC7E64.4040200@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4BCC7E64.4040200@FreeBSD.org> User-Agent: Mutt/1.4.2.3i Cc: svn-src-head@FreeBSD.org, Luigi Rizzo , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org Subject: Re: svn commit: r206843 - head/sbin/ipfw X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Apr 2010 16:36:59 -0000 On Mon, Apr 19, 2010 at 11:01:40AM -0500, Robert Noland wrote: ... > >+#ifdef TCC > >+#define U64_FMT "I64" > >+#else > >+#define U64_FMT "llu" > > This is broken on amd64. It either needs casting or the following patch... thanks, i prefer passing through an unsigned long long as in the previous version because %ju seems less portable than %llu cheers luigi