Date: Sun, 6 Sep 2009 18:07:39 +0200 From: Thierry Herbelot <thierry.herbelot@free.fr> To: "A.J. \"Fonz\" van Werven" <a.j.werven@student.utwente.nl> Cc: stable@freebsd.org, jhb@freebsd.org Subject: Re: Panic in recent 7.2-Stable Message-ID: <200909061807.40053.thierry.herbelot@free.fr> In-Reply-To: <200909061537.n86FbqhP001617@satellite.xs4all.nl> References: <200909061537.n86FbqhP001617@satellite.xs4all.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
Le Sunday 06 September 2009, A.J. "Fonz" van Werven a écrit : > Kostik Belousov wrote: > > I expect that the following patch, that is the partial merge of r194459, > > would fix it. It patches sys/vm/vm_phys.c. > > > > Index: vm_phys.c > > =================================================================== > > --- vm_phys.c (revision 194458) > > +++ vm_phys.c (revision 194459) > > @@ -382,8 +382,7 @@ > > if (pa >= seg->start && pa < seg->end) > > return (&seg->first_page[atop(pa - seg->start)]); > > } > > - panic("vm_phys_paddr_to_vm_page: paddr %#jx is not in any segment", > > - (uintmax_t)pa); > > + return (NULL); > > } > > > > /* > > Hi, > > A quick grep on the file in question revealed that there are two > functions that may panic() with "page not in any segment": the > vm_phys_paddr_to_vm_page() being patched and also the next function > vm_phys_paddr_to_segind(). I'm not exactly current with the memory > management code so this may be a very stupid question, but I'll ask it > anyway: don't both functions need to be patched? > > My apologies if I'm way off the mark here, but I'm just trying to help. you are right : there seems the vm handling has been recently updated and maybe even "those who know" may not have reviewed/updated all panic conditions (removing the panic in vm_phys_paddr_to_vm_page at least allows correct operation of a -Stable kernel, like under -Current) TfH > > Regards, > > Alphons
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200909061807.40053.thierry.herbelot>