From owner-freebsd-ppc@FreeBSD.ORG Tue Jul 10 20:09:31 2012 Return-Path: Delivered-To: freebsd-ppc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7F202106564A; Tue, 10 Jul 2012 20:09:31 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: from mail-gg0-f182.google.com (mail-gg0-f182.google.com [209.85.161.182]) by mx1.freebsd.org (Postfix) with ESMTP id 22BC38FC08; Tue, 10 Jul 2012 20:09:31 +0000 (UTC) Received: by ggnm2 with SMTP id m2so512335ggn.13 for ; Tue, 10 Jul 2012 13:09:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=8zTtrgu4H52I+YA6Yvon5sj+G3MO9IZ3BepzqhHAGHo=; b=XVZIl0FntSE6R7G7KjcFkOZZR55JZBDSLJV0QP9iXa96tD0796R/PPXFMIHHPcx6T1 LVeT7IvOvGiKVFhZTnErgLdsFAAhjMvLC13JdTp/ltA2rAXbwKgRla1qZ35fyUVJEDQ5 +fCu9XO5+TTZYgOj2sE3XkJSi6KbbYdJX4TsyBOcitqeHtM5IJhitz3uy3RBzOjkcyD6 cir0dlzzQA1aFJzlTKoQlVNogpdp9V4QPx3JyUOCzMy1ufkqMsWBnrVIrr3oj7uKJfOD FDyOay8S0lwT0qNqJPsJOq/V6DR56BhCoRkfQFNgKHGE7sV6Q8dMa8pWTERtigXZwmfT iPXA== MIME-Version: 1.0 Received: by 10.66.80.193 with SMTP id t1mr60090555pax.40.1341950969737; Tue, 10 Jul 2012 13:09:29 -0700 (PDT) Received: by 10.68.224.226 with HTTP; Tue, 10 Jul 2012 13:09:29 -0700 (PDT) In-Reply-To: References: <20120707102004.3e874201@narn.knownspace> <4FF87446.2090903@rice.edu> <4FF9F3CF.6050608@fgznet.ch> Date: Tue, 10 Jul 2012 16:09:29 -0400 Message-ID: From: Justin Hibbits To: alc@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: freebsd-ppc@freebsd.org, Alan Cox Subject: Re: Panic with latest pmap lock changes. X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jul 2012 20:09:31 -0000 On Tue, Jul 10, 2012 at 4:00 PM, Alan Cox wrote: > On Sun, Jul 8, 2012 at 3:55 PM, Andreas Tobler wrote: > >> On 07.07.12 19:39, Alan Cox wrote: >> >>> On 07/07/2012 09:20, Justin Hibbits wrote: >>> >>>> Looks like I spoke too soon about the pmap lock changes working on my >>>> G4. After about 24 hours of uptime, it panicked with the following: >>>> >>>> _rw_wlock_hard: recursing but non-recursive rw pmap pv global >>>> @ /home/chmeee/freebsd/src/sys/**powerpc/aim/mmu_oea.c:2301 >>>> >>>> I think the attached patch should fix it (Untested, except for >>>> compiling). >>>> >>>> >>> Ugh. Sorry. >>> >>> The attached patch eliminates the lock recursion. While I was doing >>> that, I noticed that the pmap_ts_referenced() implementations on powerpc >>> have the wrong return type. Oddly, the comments in mmu_if.h have the >>> return type correct, but the code two or three lines later has it wrong. >>> >> >> Fyi, I'm building world with the patch mentioned in this thread and the >> kernel updated to 238258. (G5-SMP 32-bit) >> >> So far it looks promising. >> >> Before 238258 I got reliable machine locks/freeze w/o any idea what was >> happening. >> >> If I reverted mmu_oea.c back to 238158, one before the commit from you >> Alan, I was able to get a successful full world/kernel build cycle. >> Yes, I confirmed that it booted, but I was not able to run a full >> world/kernel cycle since I lost my GEOM_APM config ;). >> >> Anyway, as said, it looks promising and it will take some hours to >> complete. >> >> > Should I commit the patch? > > Alan > > > Unfortunately the computer I was testing the patch on isn't cooperating with me (as shown in another mail), so I haven't had a chance to test it. Visual inspection looks good, though, so I'm not opposed. - Justin