From nobody Sat Jun 27 23:37:13 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gnpqL4RHqz6j8Wv for ; Sat, 27 Jun 2026 23:37:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gnpqL2mj0z3YVJ for ; Sat, 27 Jun 2026 23:37:18 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782603438; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=T5Y61I1YkNA5jrHdvJlMKHnk3XoRAD8+cQHyTuBXp8U=; b=oa8fgPKWJRWXkhcHL76yg8ds/3e0UKKeVUKEW/1N4QMhtTPztUngiMMrz/u7qd1j25xFpq d8SBFXP90z88GF3ebU10ETW5YjQhM5eCfIbFNE+DkNTy0sYn32WK5w1lV9KDpiWouwJ+SD NQVmV4Ck7SnjPMrbWQCZFFJrH4Pd7kCGEpNLf55u8Ee8SaXNbHImUJHp4jDuuVyJz6jyVI cFH/PEFrkoiWPn+v9ceQqF94SvBb8swraTo7qUZvdBLy0RPbttRP3hfGzxNuBxHWd32NgP z6VuocOwrJvpzo2q7nTmYOn2T52XLvPGWmOspoN0qRhz7Rwkmr+UQoI+UogaYQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782603438; a=rsa-sha256; cv=none; b=UWai8yU3roAoWmBmFqTF/zxxK8WC4f4l2ZNJod414PVFEA0GXPX4KVnPurtyBVtXQnZISq V60pGDlgrl6xXVzGxIqdHgU7BLywKOKBjiCAuM7ufCQlH0P3/GkFmtjWIGD20D9bl+tnFY BtJAa0b2gAVNIMifyNv4GgeW/2fkjbnO5hiTvoXGGYw6Kbws9wGMwg04RYU0CtE6RgZGXt 5pb7wGoHrLKk1zeKWWTSDLhpn5KyK+GqszJho6ud5H3wH3OnYc04gQJjMjx2jA4i6wDQyT Oma8x3cXprKeFKWZltafzKB1kD4FT/uzZiOiuShtAulugxh+QUcQmVWX1lbQpg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782603438; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=T5Y61I1YkNA5jrHdvJlMKHnk3XoRAD8+cQHyTuBXp8U=; b=RTH91zbqXCJb14Pgl9aU+Y/c6AXIAxB1cky22eu26EX7EZWjfxG5MkJl8FdPnCU5zDo6QJ 8uMfkTzT0Z6+SsiJ6ewhG2TDaZ5MduAiTNbP5CU93dlbbunkit9eYWeH2YtOP8De1/KKBP JJEixOG3vDhtgbi5+z/Wg6iFOwUYAlnXHZdai6eQLSFC74/41wOT0DpGGjGLuDIviKX3oq iGPHA/ewfXFwrMKvZ+S5kFLuLUruMjfLI3mjFzC1G56vnLRpWN3eQj7ut49GTmhiiMECq7 Ed7ynPpBOo3K0wIRPYMU6zBLaIWw7Ee+csfUczrMOFFW7krPeiAmGJIVSsPRjA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gnpqL0bMQzlgt for ; Sat, 27 Jun 2026 23:37:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3975a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 27 Jun 2026 23:37:13 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Rick Macklem Subject: git: 9e1bbfb88e98 - main - nfs_clstate.c: Fix CB_RECALL handling for NFSv4.1/4.2 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rmacklem X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 9e1bbfb88e986b209709ea765189a3ebb6581bcd Auto-Submitted: auto-generated Date: Sat, 27 Jun 2026 23:37:13 +0000 Message-Id: <6a405ea9.3975a.38006509@gitrepo.freebsd.org> The branch main has been updated by rmacklem: URL: https://cgit.FreeBSD.org/src/commit/?id=9e1bbfb88e986b209709ea765189a3ebb6581bcd commit 9e1bbfb88e986b209709ea765189a3ebb6581bcd Author: Rick Macklem AuthorDate: 2026-06-27 23:35:20 +0000 Commit: Rick Macklem CommitDate: 2026-06-27 23:35:20 +0000 nfs_clstate.c: Fix CB_RECALL handling for NFSv4.1/4.2 Recent testing with a modified NFSv4.1/4.2 client that sometimes ignored CB_RECALL callbacks, identified a few problems when handling the unusual case of CB_RECALL not be performed by the client. - The csa_cachethis argument to CB_SEQUENCE was being ignored. - The CB_SEQUENCE operation would reply NFSERR_DELAY after the first CB_RECALL attempt, making retries ineffective. - The code could return NFSERR_RESOURCE, which is a NFSv4.0 specific error code. This patch fixes the above three problems. The patch only affects the NFSv4.1/4.2 client when delegations are being issued and the client somehow fails to handle a CB_RECALL callback of a delegation, which is an unusual case. MFC after: 2 weeks --- sys/fs/nfsclient/nfs_clstate.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/sys/fs/nfsclient/nfs_clstate.c b/sys/fs/nfsclient/nfs_clstate.c index 1931964ed62e..e906de603c28 100644 --- a/sys/fs/nfsclient/nfs_clstate.c +++ b/sys/fs/nfsclient/nfs_clstate.c @@ -3585,7 +3585,7 @@ nfscl_docb(struct nfsrv_descript *nd, NFSPROC_T *p) mount_t mp; nfsattrbit_t attrbits, rattrbits; nfsv4stateid_t stateid; - uint32_t seqid, slotid = 0, highslot, cachethis __unused; + uint32_t seqid, slotid = 0, highslot, cachethis; uint8_t sessionid[NFSX_V4SESSIONID]; struct mbuf *rep; struct nfscllayout *lyp; @@ -3596,6 +3596,7 @@ nfscl_docb(struct nfsrv_descript *nd, NFSPROC_T *p) struct nfsclsession *tsep; gotseq_ok = 0; + cachethis = 0; nfsrvd_rephead(nd); NFSM_DISSECT(tl, u_int32_t *, NFSX_UNSIGNED); taglen = fxdr_unsigned(int, *tl); @@ -3922,6 +3923,9 @@ nfscl_docb(struct nfsrv_descript *nd, NFSPROC_T *p) error = nfsv4_seqsession(seqid, slotid, highslot, tsep->nfsess_cbslots, &rep, tsep->nfsess_backslots); + /* For callbacks, do not reply NFSERR_DELAY. */ + if (error == NFSERR_DELAY) + error = 0; } NFSUNLOCKCLSTATE(); if (error == 0 || error == NFSERR_REPLYFROMCACHE) { @@ -4065,8 +4069,9 @@ nfsmout: } *nd->nd_errp = nfscl_errmap(nd, minorvers); out: - if (gotseq_ok != 0) { + if (gotseq_ok != 0 && cachethis != 0) { rep = m_copym(nd->nd_mreq, 0, M_COPYALL, M_WAITOK); + NFSCL_DEBUG(4, "Got reply for cbcache=%p\n", rep); NFSLOCKCLSTATE(); clp = nfscl_getclntsess(sessionid); if (clp != NULL) { @@ -5283,6 +5288,8 @@ nfscl_errmap(struct nfsrv_descript *nd, u_int32_t minorvers) while (*++errp) if (*errp == (short)nd->nd_repstat) return (txdr_unsigned(nd->nd_repstat)); + if (minorvers > NFSV4_MINORVERSION && *defaulterrp == NFSERR_RESOURCE) + return (txdr_unsigned(NFSERR_SERVERFAULT)); return (txdr_unsigned(*defaulterrp)); }